subsurface.git/desktop-widgets, branch v5.0.3

Remove the divecomputer naming tab

2021-08-18T20:22:02Z

The TabDiveComputer model won't work in the new world order, where you can't even insert a new device entry without a nickname to be edited. Signed-off-by: Linus Torvalds

desktop: fix crash when right-clicking of trip headers

2021-08-12T18:57:26Z

Commit e42fc1a1e9a13c77d3474dbcb26b68b8772b8c6d introduced a crash condition. Apparently the code attempts to test whether the clicked-on item is a top-level dive. The "Collapse others" menu item should not be shown in that case. It does this by testing "d->divetrip". However, "d" might quite logically be null if clicking on an unexpanded trip header. Therefore, check explicitly for the trip header case (which should show the menu item) and for good measure prevent the nullpointer access (that should be caught by testing for trip, but who knows). Fixes #3301. Signed-off-by: Berthold Stoeger

cleanup: replace membuffer by membufferpp in C-code

2021-07-23T18:22:43Z

Thus, the membuffer data is automatically freed when going out of scope - one thing less to worry about. This fixes one use-after-free bug in uploadDiveLogsDE.cpp and one extremely questionable practice in divetooltipitem.cpp: The membuffer was a shared instance across all instances of the DiveToolTipItem. Remves unnecessary #include directives in files that didn't even use membuffer. Signed-off-by: Berthold Stoeger

desktop: explicitly enable shortcuts

2021-07-23T17:20:50Z

The changes in commit 4daf687876 ("profile: remove [disable|enable]Shortcuts() signals") resulted in us no longer enabling the shortcuts on the desktop (at least on macOS where I debugged this). This placement of the call feels like a bit of overkill, but at least it shouldn't be wrong. Fixes #3293 Signed-off-by: Dirk Hohndel

cleanup: remove Printer::dpi member variable

2021-07-07T14:57:11Z

This variable is not used outside a single function, where it is reset every time the function runs. This can be realized by a function-local variable just as well. Signed-off-by: Berthold Stoeger

Handle dives with no samples

2021-07-03T21:38:19Z

This occurs upon importing dives for example via CSV. Make sure the profile display is cleared when selecting such a dive rather than showing a different dive. Allow editing the profile for such a dive. Signed-off-by: Robert C. Helling

profile: rename ADD state to EDIT state

2021-07-03T21:30:46Z

The ADD state is not used for adding dives since adding dives was made undoable. Therefore, rename it to EDIT state, since that is what it is used for. Signed-off-by: Berthold Stoeger

cleanup: update copyrights

2021-07-03T21:28:37Z

That should have been done six months ago. Signed-off-by: Dirk Hohndel

cleanup: remove long obsolete code

2021-07-03T21:28:37Z

We have stopped playing with beta versions many many years ago. Signed-off-by: Dirk Hohndel

desktop: add numerus translation for dive context menu

2021-06-04T16:35:16Z

Add numerus translation lookup for the right-click context menu in the dive list to show proper singular/plural text. Fixes #3256 Signed-off-by: Mark Stiebel Signed-off-by: Dirk Hohndel