subsurface.git/dives, branch v4.0

Correctly parse multiple tags in the divelog

2013-12-13T00:29:06Z

The old parsing code overwrote the first comma with a '\0' and then checked the index against the length of the buffer - which was changed by replacing the ',' with the '\0'. This means that since commit 78acf20848c0 ("Don't crash on loading tags longer than 127 chars") Subsurface has potentially damaged / lost data in dive files! Added a test dive that shows the issue if opened by a Subsurface version after the commit mentioned above but before this commit. Reported-by: Miika Turkia Signed-off-by: Dirk Hohndel

Different Icon for a Bookmark Event.

2013-12-05T03:41:29Z

This patch adds a different icon for a Bookmark Event, and it also cleaned a lot of code. :) See #300 [Dirk Hohndel: made the two icons slightly bigger] Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Allow comma separated CSV files

2013-12-04T23:27:09Z

The separator selector in the CSV import dialog was unused. This passes the value into the xslt and adds ',' as possible value. I'm sure this could be done much better (pass the actual character instead of the index), but I couldn't get that to work and this does seem to do the trick. Also added a test dive to test this feature. Fixes #321 Signed-off-by: Dirk Hohndel

Change gas in second cylinder in sac-test-dives

2013-12-02T20:33:47Z

Due to that we can't handle gaschanges to the same gas in another cylinder, this changes the second gas to EAN22 to workaround that. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Add test dive with tank pressure sensor information

2013-10-15T11:12:16Z

This is a real data from a Uemis Zurich divecomputer. Signed-off-by: Dirk Hohndel

Sample dive from APDLogViewer

2013-10-03T16:39:37Z

Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel

Test dive for CSV import

2013-10-02T17:18:16Z

This test dive follows the format of APD Log Viewer but contains only the currently used data (time, depth, and temperature). Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel

Adjust test dives to comply with the current trip syntax

2013-05-16T04:36:34Z

Otherwise the tests fail - we no longer support the old format. Signed-off-by: Dirk Hohndel

Suunto DM4 sample dive

2013-03-05T19:08:08Z

Both in .db and exported XMK format. Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel

Test dives

2013-02-26T16:50:05Z

On Tue, Feb 26, 2013 at 6:19 PM, Dirk Hohndel wrote: > Miika Turkia writes: > >> On Tue, Feb 26, 2013 at 5:54 PM, Dirk Hohndel wrote: >>> Miika Turkia writes: >>> >>>> On Tue, Feb 26, 2013 at 6:45 AM, Dirk Hohndel wrote: >>>>> I added a few test dives exported from other software (Dm3, DiveLog 5.08, >>>>> JDiveLog 10.2 from Mac - last one doesn't parse because of encoding... Also >>>>> a composed XML zip file from DiveLog isn't supported, yet) >>>>> Find them under dives >>>> >>>> Now this gets interesting. Is there ANY logic in the units in the >>>> dives/TestDiveDiveLog5.08.xml? It seems that some of the temperatures >>>> are in C (Airtemp and Watertemp) and some in F (samples). Otherwise I >>>> would guess we are talking metric here, but I do not see any specs >>>> (another log I have seen from DivingLog had all the units in metric, >>>> as far as I could guess). BTW is the Weight in kg or lb? >>> >>> I have purchased DivingLog and should be able to create any combination >>> of data for the test file that we could possibly want. I'll do a set in >>> a moment that describe what SHOULD be there in their notes, maybe that >>> will clear things up. >>> >>> That said, I really want to release 3.0.1 in the next couple of hours, >>> so this may have to wait for 3.0.2 (if we end up needing that) or 3.1. >>> >>>> The divelogs.de UDCF format looks like it shouldn't take long to write >>>> support for. I'll look into it this evening. >>> >>> It is evening for you, right? No pressure, just making sure I understand >>> what may be coming in in patches in the next hour or two >> >> I currently have one version of the DivingLog XSLT. So a bit of >> verification and that could possibly be used as is. However, this >> could use a bit more testing than a new support to make sure things >> are not going to be any worse than they currently are. >> >> I have not started with the UDCF yet, but that could be reasonably >> fast to implement. However, no guarantees. (And yes, it is evening for >> me) > > I can hold off 3.0.1 a couple hours longer if that is a realistic thing > to do. I don't see the UDCF as that important since we have a different > format from them that we support. So I think the best possible DivingLog > support would be my preference. > > I'll add a few more exported dives from DivingLog next (and fix the > naming of the existing ones). In that case, here is the DivingLog XSLT if anyone can give it a test. miika From 4a62058f4f6fd4780f04bce6e1fe45e20abcf33f Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Tue, 26 Feb 2013 17:46:53 +0200 Subject: [PATCH] XSLT for DivingLog Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel