subsurface.git/map-widget, branch v4.9.1

Cleanup: construct MapWidgetHelper::pluginObject()

2019-05-11T19:06:19Z

Instead of multiple string-concatenations, create the string object from a single string literal. Yes, this is a mostly pointless "optimization". But it saves a few bytes. Signed-off-by: Berthold Stoeger

Map: automatically update names on the map

2019-05-11T19:06:19Z

Currently, dive site names are only updated on full reload. Instead hook directly into the corresponding signal in the MapLocationModel to set the name. Also to the coordinates directly there instead of going via the MapWidgetHelper. In the MapWidgetHelper, just center on the changed dive site. Hook into the signal directly there and remove the slot from the MapWidget. This makes the whole call-chain at least one call shorter. Signed-off-by: Berthold Stoeger

Map: ignore dive sites without location in centerOnSelectedDiveSite()

2019-05-11T19:06:19Z

Don't zoom onto (0,0) for selected dive sites that have no location. Signed-off-by: Berthold Stoeger

Map: in edit mode place no-gps dive sites at center of map

2019-05-11T19:06:19Z

Move the code to add the first selected dive site from MapWidgetHelper::enterEditMode() to MapLocationModel::reload(). Thus, the list of sites is built only at one place. For this it is necessary to pass a pointer to the map, so that new dive sites can be added at the center of the map. Signed-off-by: Berthold Stoeger

Map: don't recalculate selected dive sites

2019-05-11T19:06:19Z

In MapWidgetHelper::centerOnSelectedDiveSite() the selected dive sites were recalculated. Simply use the ones we already know are selected. Signed-off-by: Berthold Stoeger

Map: make edit mode depend on dive-site-filtering

2019-05-11T19:06:19Z

Since the dive-site-filter is active either on the dive-site-edit page or the dive-site-list page, use that as the flag for dive-site-edit mode. Moreover, when the filter is reset, the MapWidgetHelper::reloadMapLocations() function is called, so we can use that place to enter/exit edit mode. This makes it easier to keep everything consistent. Signed-off-by: Berthold Stoeger

Map: remove dead code

2019-05-11T19:06:19Z

When entering map-edit mode and the dive site existed, its coordinates were extracted but never used. Remove that useless if-branch. Signed-off-by: Berthold Stoeger

Cleanup: remove MapWidgetHelper::m_selectedDiveIds member

2019-05-11T19:06:19Z

This member variable was only used locally in functions. Accordingly, make it a function-local variable. Signed-off-by: Berthold Stoeger

Map: don't set map selection in selectVisibleLocations()

2019-05-11T19:06:19Z

MapWidgetHelper::selectVisibleLocations() calls setSelection() on a single dive. Firstly, this make no sense anymore, as we now support multiple highlithed flags. Secondly, the highlted dives are now derived from the selected dives. Therefore, remove the call. Signed-off-by: Berthold Stoeger

Map: don't update map-selection in centerOnSelectedDiveSite()

2019-05-11T19:06:19Z

To detangle this code a little bit, let centerOnSelectedDiveSite() just do what is says: center on the selected dive sites. Don't update the selected dive site by calling MapLocationModel::setSelected(). Signed-off-by: Berthold Stoeger