subsurface.git/map-widget, branch v4.9.8

Revert "map: remove selectedDivesChanged"

2020-04-27T12:48:37Z

This reverts commit cd474996948b7592ab2973b7f936320a663a914e. The signal removed in the reverted commit was used in Subsurface-mobile. So removing it, caused a not running app. Signed-off-by: Jan Mulder

maps: disable link to Google maps on iOS and Android

2020-04-25T20:18:41Z

It appears that on those two platforms you now need a paid API key in order to have this feature work. Certainly not something I'm going to do. Signed-off-by: Dirk Hohndel

map: remove selectedDivesChanged

2020-04-25T20:05:31Z

The qml-widget seems to catch selectedDivesChanged signals of the MapWidgetHelper and reemit them. However, there seems to be nobody listening to this signal? Let's remove this for now to make debugging of the signals easier. Signed-off-by: Berthold Stoeger

maps: show the dive site when opening Google map

2020-04-20T01:52:15Z

I'm not sure if Google used to show the POI marker at the center location in the past or if this is actually a new feature. Either way this appears to do the right thing in my testing. Note that we need a 'plus' to connect the point of interest cooridnates, but a 'comma' to connect the map center coordinates. Reported-by: Chirana Gheorghita Eugeniu Theodor Signed-off-by: Dirk Hohndel

cleanup: split uiLanguage() in two functions

2020-03-22T19:01:09Z

The uiLanguage() function was used for two purposes: to initialize the language related preferences and to read the current language. To make things more easy to follow, split this function in two: one for initializing, one for getting the current language. Moreover, don't return the current locale in an out-parameter as there is already a function to do that [getLocale()]. Signed-off-by: Berthold Stoeger

Grammar: replaces 'indexes' by 'indices'

2020-03-11T15:26:30Z

Grammar-nazi ran git grep -l 'indexes' | xargs sed -i '' -e 's/indexes/indices/g' to prevent future wincing when reading the source code. Unfortunatly, Qt itself is infected as in QModelIndexList QItemSelection::indexes() const Signed-off-by: Robert C. Helling

Cleanup: lower-case filenames in core/subsurface-qt/

2020-02-04T01:16:46Z

We tend to use lower-case filenames. Let's do it for these files as well. Simple search & replace. Signed-off-by: Berthold Stoeger

build-system: Add CMakeLists.txt to map-widget

2019-12-23T21:18:36Z

In order to make the central CMakeLists cleaner and more consistent add a CMakeLists.txt to map-widget, like in other root directories. Signed-off-by: Jan Iversen

Filter: split out filter from model

2019-11-20T05:13:40Z

Split out the actual filtering from the MultiFilterSortModel. Create a DiveFilter class that does the actual filtering. Currently, mobile and desktop have their own version of this class, though ultimately we may want to merge them. The idea here is that the trip-model and undo-commands have direct access to the filter-function and thus can take care of keeping track of the number of shown dives, etc. Signed-off-by: Berthold Stoeger

Cleanup: remove accessor functions from MapLocation

2019-09-06T18:48:47Z

Let's face it: this is a value type. No point in having Java-style getters and setters. Replace by plain old and boring member variables. Signed-off-by: Berthold Stoeger