subsurface.git/mobile-widgets, branch v4.7.6

Cleanup: avoid out of bounds access

2017-12-26T23:57:45Z

sizeof() is clearly the wrong way to get to the size of that array... Coverity CID 208297 Signed-off-by: Dirk Hohndel

Cleanup: check we have dive before dereferencing

2017-12-26T21:41:58Z

Coverity CID: 208341 Signed-off-by: Dirk Hohndel

mobile: close GPS menu drawer when selected

2017-12-26T21:08:37Z

This is mainly a cosmetic improvement. The GPS menu stayed visible, when selecting most of the options. This looks weird, as the close of the menu is also an indication of the selected action carried out. So, just close it Signed-off-by: Jan Mulder

CHANGELOG.md

2017-12-18T14:23:23Z

Signed-off-by: Jan Mulder

mobile: exit edit mode when navigating away from edit page

2017-12-18T14:23:23Z

Navigating using the breadcrumb in the header did leave the dive detail edit (and add) mode in such a way that (for example) navigation in the dive list was suspended. Obviously, it is debatable what should be done. Saving the edits/add, or cancelling them. For now, this commit cancels them silently. This is the exact same thing that is happening when the user selects the dive list from the drawer menu. Fixes: #932 Signed-off-by: Jan Mulder

Cleanup: fix potential uninitialized use of uuid

2017-12-17T17:12:44Z

And make sure we don't create a dive site for an empty location string. Signed-off-by: Dirk Hohndel

mobile: use short date format in edit mode

2017-12-17T17:04:16Z

See issue #949. In the dive list, dates are shown in short format, and when we start to edit an existing dive, the date field on the edit page is shown in sort format. However, when adding a new dive, the initial date shows up in long (normal) format. This in not only inconsistent, but also introduces the parsing problem, as described in the mentioned issue. This can be fixed by using short formatted dates in all cases in the mobile app. As the screen real estate is precious on mobile, this seems the most logical choice. Fixed: #949 Signed-off-by: Jan Mulder

mobile: manual add dive and cancel fails when repeated

2017-12-17T03:04:57Z

This commit fixes a very subtle bug. Probably there for ages, but never noticed. When manually adding a dive, and canceling the add right away, the divetable was extended by 1 dive (using the core function add_single_dive), but canceling never removed that dive (using delete_single_dive). This is corrected here. Notice that commit ef543da5aff296e claims to fix issue #950. With this commit, however, that issue can be seen sometimes again. Signed-off-by: Jan Mulder

mobile: clear internal data when edit/add dive is finished

2017-12-15T17:03:24Z

When editing (or adding) a dive, the internal data containing the attributes on the edit page was not cleared when editing was finished (in any way, by saving the edit or by cancelling it). As long as the user only edits existing dives, all this poses no problem, as at the start of a dive edit, the data is filled from the dive to be edited. However, when adding a dive, data coming from previous edits shows up. This not clearing data also causes the strange effect as written in issue #950: adding a dive, deleting it, and adding a dive again, added the first added dive data, without the edit screen being shown. All this can be solved by clearing the data from the edit when editing is done. Fixes: #950 Signed-off-by: Jan Mulder

mobile: show message when going offline

2017-12-14T16:01:51Z

Trivial fix. Show the message "Turning off automatic sync to cloud ..." when turning automatic sync to offline. Just a more logical moment to show this message. Also rephrase the message "Enable auto sync" to "Auto sync enabled". It shows a status, and not an action. Signed-off-by: Jan Mulder