subsurface.git/mobile-widgets, branch v4.7.7

Mobile cleanup: remove unused actions

2018-02-08T20:29:47Z

Trivial removal of 2 unused Kirigami actions. These were leftovers from the time we had a very different style of cloud account management. Signed-off-by: Jan Mulder

mobile cleanup: repair stupid mistake

2018-02-02T12:13:46Z

Commits fed2c5b6a1 and 572fc4707 erroneously deleted two aliases. That is corrected here. Yes, QML with only runtime errors can be a pain. Signed-off-by: Jan Mulder

mobile: introduce simple private helper updateAllGlobalLists()

2018-01-31T13:48:14Z

As we need to update our new stringlist models on multiple locations, just refactor them into a new function. Signed-off-by: Jan Mulder

mobile cleanup: restyle construction of locationlist

2018-01-31T13:48:14Z

See also e6e1473e6. The construction of the locationlist was not the same as the 3 previous lists, and it needs the inclusion of a new model file (divelocationmodel.cpp) in the mobile app. In addition, as the mobile app is mainly interested in a simple stringList (model) to populate a HintsText field (or maybe later a combobox), this stringlist is added to the model, to easy interfacing with QML. Signed-off-by: Jan Mulder

mobile cleanup: unduplicate code and do not loop over dives (3)

2018-01-31T13:48:14Z

See e6e1473e6. Exact same commit but here for the list of divemaster. The careful reader will spot a small addition to the clearDetailsEdit() QML function. Two more field are cleared. Signed-off-by: Jan Mulder

mobile cleanup: unduplicate code and do not loop over dives (2)

2018-01-31T13:48:14Z

See e6e1473e6. Exact same commit but here for the list of buddies. Signed-off-by: Jan Mulder

mobile cleanup: unduplicate code and do not loop over dives (1)

2018-01-31T13:48:14Z

This is the first of a set of commits that are (very) similar. It appeared that a number of more or less static lists, which are constructed by a loop over all dives in the logbook, were executed when changing focus to a next dive. For example, the in this commit addressed list of used dive suits. What was wrong was that the suitList was linked to a dive. There is only a need to construct the list of used suits when data is changed (and obviously, once on startup of the app). Further, it appeared that a lot of code was duplicated and that we can use (in this case) the same code from the desktop completionmodels.cpp. Basically, this commit involves the following changes: - include completionmodels.cpp in mobile and desktop (so move it from the desktop only category to the generic category). - remove double code from DiveObjectHelper.cpp - Do not differentiate in the init phase and the normal refresh of the list - the per dive logic is now only the getting of a previously constructed list (in init or update of the divelist). There are no visible changes in the UI, other than a better performance when scrolling over dive details. Signed-off-by: Jan Mulder

Make report_error() reentrant

2018-01-31T13:47:26Z

Remove the global error buffer and pass the error string directly to the frontend. The frontend is then responsible for accumulating errors. Signed-off-by: Berthold Stoeger

Use error callback to log errors in QMLManager

2018-01-31T13:47:26Z

Instead of manually logging errors after each potentially error-producing function, use the error-callback. The error texts are accumulated in the QMLManager object for further use. The text is transported to the QMLManager object via a queued connection. Thus, errors can be reported from other threads without having to deal with manual locking. Signed-off-by: Berthold Stoeger

Remove function-call indirection in qmlmanager.cpp

2018-01-25T07:39:20Z

QMLManager::tryRetrieveDataFromBackend() was a one-liner calling void QMLManager::checkCredentialsAndExecute() with a pointer-to-member. The latter was never called with a different pointer, therefore fold the latter into the former and remove the indirection. Signed-off-by: Berthold Stoeger