subsurface.git/mobile-widgets, branch v4.8.4

Mobile: Allow multiple divemasters

2018-11-15T10:10:13Z

While not something that many will use, editing a dive on Subsurface-mobile should not result in data loss. This makes the divemaster field behave in the same way as the buddy field with regards to multiple entries. Fixes #1853 Signed-off-by: Joakim Bygdell Signed-off-by: Dirk Hohndel

Mobile/filtering: don't show the filter line when pulling divelist down

2018-10-31T21:34:43Z

Even though the height was zero, when pulling down the dive list for refresh, the filter input line would still be visible. With this fix it no longer is. Also remove unused property. Signed-off-by: Dirk Hohndel

Dive site: replace dive->dive_site_uuid by dive_site

2018-10-29T00:09:31Z

Replace the UUID reference of struct dive by a pointer to dive_site. This commit is rather large in lines, but nevertheless quite simple since most of the UUID->pointer work was done in previous commits. Signed-off-by: Berthold Stoeger

Dive site: replace UUID by pointer in mobile code

2018-10-29T00:09:31Z

Replace UUIDs by pointers to dive-site in mobile code. In both cases, the value is transported via a QVariant. The function getCoordinatesForUUID(), which was only used from mobile, can be replaced by a getCoordinatesFor() function taking a variant supposed to contain a dive-site pointer. Likewise, the variant of the centerOnDiveSite function is now supposed to wrap a pointer-to-divesite. Signed-off-by: Berthold Stoeger

Dive site: return pointer to dive_site in create_dive_site_*()

2018-10-29T00:09:31Z

This changes more of the dive-site interface to return pointers instead of UUIDs. Currently, most call sites directly extract UUIDs afterwards. Ultimately, the UUIDs will be generally replaced by pointers, which will then simplify these callers. Signed-off-by: Berthold Stoeger

Dive site: return pointer to dive_site in get_dive_site_*()

2018-10-29T00:09:31Z

As a first step in removing dive-site uuids, change the interface of the get_dive_site_*() functions to return pointers instead of uuids. This makes code a bit more complicated in places where the uuid is extracted afterwards (needed NULL check). Nevertheless, these places should disappear once pointers instead of uuids are stored in the dive-structures. Signed-off-by: Berthold Stoeger

QML UI: we don't need Controls 2.4

2018-10-27T14:17:51Z

In commit 99c06dec3d ("Mobile/filtering: simple busy indicator") we switched to Controls 2.4 which requires Qt 5.11. Revert that one line of the commit as it isn't necessary. Signed-off-by: Dirk Hohndel

Mobile/filtering: make busy indicator smaller

2018-10-23T21:45:30Z

Suggested-by: Jan Mulder Signed-off-by: Dirk Hohndel

Mobile/filtering: update number of dives shown when resetting filter

2018-10-23T21:45:30Z

Otherwise we start showing an illogical '0' there when first opening the filter dialog, and the equally wrong previous count when closing and then re-opening the filter dialog. Reported-by: Jan Mulder Signed-off-by: Dirk Hohndel

QML UI: remove some of the log file noise

2018-10-23T21:45:30Z

A couple came from this series, others are much older. Signed-off-by: Dirk Hohndel