subsurface.git/mobile-widgets, branch v4.9.4

cleanup: replace constructs of the type &vector[0] by vector.data()

2020-04-21T14:50:38Z

It appears that some misguided compiler / library combinations crash on &vector[0] for empty vectors. Even though very unfriendly, they are technically correct, so let's remove these constructs. Signed-off-by: Berthold Stoeger

mobile UI: indicate status of verbose flag

2020-04-18T16:00:21Z

This way the user can verify that they have set the log to verbose mode in the developer menu. Signed-off-by: Dirk Hohndel

mobile: don't call main loop for notifications once initialized

2020-04-13T15:33:47Z

Calling qApp->processEvents() in QMLManager::setNotificationText() caused crashes, because it could lead to the context-menu that initialized the call being deleted. Something that QML apparently doesn't like. Signed-off-by: Berthold Stoeger

mobile: remove overwriting of line special case in ui-notification

2020-04-13T15:30:51Z

On startup, we showed progress of the population of the fulltext and listmodels for every 100th dive. This worked by overwriting the last line if the new line started with '\r'. Since we don't do that anymore, we can remove this special case. Signed-off-by: Berthold Stoeger

mobile/startup: fix potential crash when switching back and forth

2020-04-04T23:12:52Z

If the user switches away from Subsurface-mobile and back while we are in our initialization phase, that code might run more than once leading to undesirable results. Signed-off-by: Dirk Hohndel

mobile/cleanup: create helper function to hide verbose casts

2020-04-04T23:10:50Z

The strange enum casts (that apparently we needed in order to have strongly typed enums in QML) are really ugly and confusing in the code. Since we had this three times it seemed worth to create a little helper that hides this nonsense. Signed-off-by: Dirk Hohndel

mobile/cloud-storage: correctly transition from no-cloud to cloud

2020-04-04T23:10:50Z

We know that we have valid credentials, so calling openLocalThenRemote() makes no sense, worse, it doesn't respect the special case of transitioning between accounts. That's the whole point of having a separate loadDivesWithValidCredentials() call. Once we have transitioned state, we need to record the now current state as the old state so that future transitions will work. Signed-off-by: Dirk Hohndel

mobile/cloud-storage: fix test for no cloud to cloud transition

2020-04-04T23:10:50Z

The noCloud variable contains our desired state, we need to test for the previous state for this to make sense. Signed-off-by: Dirk Hohndel

mobile/cleanup: remove outdated comment and fix whitespace

2020-04-04T23:10:50Z

We haven't supported the GPS web service for a long time. Also, add another message for the log to be able to more easily trace one error case. Signed-off-by: Dirk Hohndel

mobile/undo: set undo stack as clean after save

2020-04-04T23:09:57Z

If we're using the undo stack for determining the whether there are unsaved changes, we have to mark the undo stack as clean after save. This duplicates code from desktop. It is planned to unify this in the near future. Signed-off-by: Berthold Stoeger