subsurface.git/mobile-widgets, branch v4.9.9

mobile: add missing word to location warning

2020-11-05T22:22:15Z

Thanks to Johan, one of our Swedish translators for noticing this oversight. Signed-off-by: Dirk Hohndel

cleanup: remove struct/class confusion

2020-10-27T02:27:03Z

DiveSiteChange is defined as a struct, not as a class. Signed-off-by: Dirk Hohndel

cleanup: move application flags to core/subsurfacehelper.h

2020-10-25T20:59:52Z

These flags are not dive-related, therefore move their declaration to the appropriate header file. Likewise, move their definition from parse-xml.c to subsurfacehelper.c Signed-off-by: Berthold Stoeger

cleanup: move mark_divelist_changed() to qmlmanager.cpp

2020-10-25T20:59:04Z

Desktop does not use mark_divelist_changed() anymore - all is done via the undo machinery. Therefore move this function (and its counterpart unsaved_changes()) to qmlmanager.cpp. Ultimately, it probably should be removed from there as well, but currently I don't dare to touch all the cloud-logic! Signed-off-by: Berthold Stoeger

git: add device-table to git-parser-state

2020-10-24T16:51:37Z

In analogy to the xml-parser add a device-table to git's parser-state. Currently this is unused. In upcoming commits the git parser will then be changed to add device nodes in this table instead of the global device table. The long-term goal being to detach the parsers from global state and to make dive-import fully undoable. Signed-off-by: Berthold Stoeger

devices: add devices in Command::importTable()

2020-10-24T16:51:37Z

Add a device_table parameters to Command::importTable() and add_imported_dives(). The content of this table will be added to the global device list (respectively removed on undo). This is currently a no-op, as the parser doesn't yet fill out the device table, but adds devices directly to the global device table. Signed-off-by: Berthold Stoeger

devices: add functions to add / remove / check for devices

2020-10-24T16:51:37Z

To include the device code in the undo system, we need functions to check for the existence of devices and to add or remove them. Signed-off-by: Berthold Stoeger

parser: add device_table to parser state

2020-10-24T16:51:37Z

If we want to avoid the parsers to directly modify global data, we have to provide a device_table to parse into. This adds such a state and the corresponding function parameters. However, for now this is unused. Adding new parameters is very painful and this commit shows that we urgently need a "struct divelog" collecting all those tables! Signed-off-by: Berthold Stoeger

mobile: show location service warning

2020-10-24T16:47:37Z

Google play now requires that we show an explicit notification when turning on background location. This is an attempt to fulfill that requirement - we won't know if this is 'good enough' until we submit the app, though. Signed-off-by: Dirk Hohndel

mobile: show text with location service icon

2020-10-24T16:47:37Z

I don't recall why we removed that text, but this makes it much clearer that the service is active. Signed-off-by: Dirk Hohndel