subsurface.git/profile-widget, branch v4.7.7

Free various struct membuffer in different functions

2018-02-02T19:29:55Z

Signed-off-by: Stefan Fuchs

profile: replot handles while planning

2018-01-31T13:48:31Z

The settingsChanged() function of the profile widget tries to be clever and tries to prevent not needed replots of the profile. I'm not sure this is very relevant in the first place as change of settings are almost instantly, with or without replot. It appears that replot is always executed when there are calculated ceilings visible. But without calculated ceilings a replot is "optimized out". This does, however, introduce dangling divehandles in PLAN/EDIT and ADD mode of the profile, when any setting that influences the y-axis is changed. The fix is trivial. Just force a replot in the PLAN/EDIT and ADD modes. Fixes: #1070 Signed-off-by: Jan Mulder

Planner: print icd information at 0.1 resolution

2018-01-24T21:03:42Z

The gas fractions (in %) are now printed at a resolution of 0.1% and not at 0.01% as previously. The string in the info box that provides icd data is reformatted so that the info-box is as narrow as possible. Signed-off-by: Willem Ferguson

profile: fix weird disappearance of cylinder pressure line

2018-01-24T15:19:19Z

The reason for this issue, and fix for this is very similar to commit b4d37e8ee. Just set both recalculate flags on a mouse release event, so that the cylinder pressure line is recalculated. Signed-off-by: Jan Mulder

Profile info box ICD: Change format of ICD string

2018-01-21T17:01:56Z

Change the format from (example!) ICD: ΔHe=-34% ΔN₂=3%<3% to ICD: ΔHe=-34% ΔN₂=+3%<+2.8% Change strings given to translation to less complex ones. Signed-off-by: Stefan Fuchs

Only give ICD warning if pN2 increases

2018-01-21T14:24:46Z

as otherwise there are warning on the descent. The ICD line in the info box is generated for all gas switches with decreasing He content. Also change the presentation in the info box to align it with the notes. Signed-off-by: Robert C. Helling

Show ICD in gaschange icons

2018-01-21T14:24:46Z

Add an exclamation mark in the gas change icons if the change violates our isobaric counter diffusion criterium. Signed-off-by: Robert C. Helling

Show ICD events data in infobox

2018-01-21T14:24:46Z

If a gas switch violates our ICD criteria, show this in the info box. Signed-off-by: Robert C. Helling

profile: fix garbled profiles after visiting the planner

2018-01-12T18:26:05Z

See mentioned GitHub issue for the full issue, and images. The reason for this weird behavior is the existence of 2 flags in the profile code: shouldCalculateMaxTime and shouldCalculateMaxDepth. When exactly following the use case and test data as attached to the GitHub issue (a very short dive, shorter than most of the dives in the logbook), the shouldCalculateMaxTime flag never got back to its true status, causing the the time scale not to adapt to other dives when just clicking (or selecting) them from the dive list. The problem is fixed here by also setting the shouldCalculateMaxTime flag on manipulating wayppoints in the dive plan. Fixes: #1039 Signed-off-by: Jan Mulder Signed-off-by: Jan Mulder

Introduce helper function empty_string()

2018-01-11T05:07:13Z

There are ca. 50 constructs of the kind same_string(s, "") to test for empty or null strings. Replace them by the new helper function empty_string(). Signed-off-by: Berthold Stoeger