subsurface.git/profile-widget, branch v4.8.1

Dive pictures: detach ProfileWidget2 from DivePictureModel

2018-07-08T18:00:44Z

As long as ProfileWidget2 and DivePictureModel showed the same set of pictures and any change would lead to a full recalculation of the set, it made sense to let ProfileWidget2 use DivePictureModel's data. Recently, keeping the two lists in sync become more and more of a burden. Therefore, disconnect ProfileWidget2 and DivePictureModel. This will lead to some code-duplication and perhaps a temporary drop in UI-performance, but in the end the code is distinctly simpler and also more flexible. Thus, for example the DivePhotoTab could be changed to support headings without having to touch ProfileWidget2 at all. Signed-off-by: Berthold Stoeger

Profile context menu entry to split a dive

2018-07-03T21:47:15Z

Allow the user to manually split a dive in two. Signed-off-by: Robert C. Helling

core/profile: move PP_GRAPHS_ENABLED from pref.h

2018-07-03T21:32:30Z

PP_GRAPHS_ENABLED is only used in profilewidget2.cpp make local to profilewidget.cpp Signed-off-by: Jan Iversen core/profile: move PP_GRAPHS_ENABLED from pref.h

Dive pictures: connect DivePictureModel signals in constructor

2018-06-29T00:12:19Z

The DivePictureModel signals were connected int the setProfileState() function of ProfileWidget2. If this function was called repeatedly (e.g. after adding a dive), multiple connections were made, which led to multiply delivered signals. This in turn led to confusion, when deleting pictures (i.e. multiple pictures were deleted). Instead, connect once in ProfileWidget2's constructor. It is unclear whether these signals should be disconnected temporarily if no pictures are shown. In any case, the weren't, so this shouldn't introduce any regression. Fixes #1441 Signed-off-by: Berthold Stoeger

Copy divemode to Replan

2018-06-24T07:35:55Z

this needs copying the divemode from the dive to the plan. Signed-off-by: Robert C. Helling

Change from gettextFromC::instance()->tr() to gettextFromC::tr();

2018-06-18T05:42:39Z

Code cleanup. Suggested-by: Berthold Stoeger Signed-off-by: Stefan Fuchs

Use correct "tr" call for translating dive mode names

2018-06-18T05:42:39Z

Correctly use gettextFromC::instance()->tr(); instead of a simple tr(); to translate the dive mode names. This goes on top of 0bc9edf855caf95e2d58ccaf704ceeda079e06f1 and finally makes the whole thing work. Signed-off-by: Stefan Fuchs

Fix an error around translation of dive modes in the UI

2018-06-16T21:36:20Z

This fixes an mistake introduced in 3d1072f8862e4c329dc2678df52a24137b8d4704 Signed-off-by: Stefan Fuchs

Enable translation for even name "modechange"

2018-06-16T21:36:20Z

Enable translations for dive event name "modechange". But clearly don't do this for the string which is used internally but only push "modechange" to the translation system to be able to translate it in the UI. Signed-off-by: Stefan Fuchs

Remove a useless translation in diveeventitem.cpp

2018-06-16T21:36:20Z

Giving the string ": %1" to translation makes no sense. And it's also not consistent with code a few lines below this line. Signed-off-by: Stefan Fuchs