subsurface.git/profile-widget, branch v4.9.10

cleanup: replace deprecated swap() usage

2020-10-27T02:27:03Z

Instead of using the two different ways Qt supports swap, depending on the Qt version in use, let's simply use std::swap() Suggested-by: Berthold Stoeger Signed-off-by: Dirk Hohndel

cleanup: replace deprecated pos() member

2020-10-27T02:27:03Z

Again, replacement was just recently added. Signed-off-by: Dirk Hohndel

cleanup: replace long obsolete delta() member

2020-10-27T02:27:03Z

This has been deprecated for years. The delta() member dealt with the old style mouse wheel that is associated with a vertical scroll - so we need the y-component. Signed-off-by: Dirk Hohndel

cleanup: split out divecomputer functions from dive.c

2020-10-25T20:59:52Z

Since dive.c is so huge, split out divecomputer-related functions into divecomputer.[c|h], sample.[c|h] and extradata.[c|h]. This does not give huge compile time improvements, since struct dive contains a struct divecomputer and therefore dive.h has to include divecomputer.h. However, it make things distinctly more clear. Signed-off-by: Berthold Stoeger

cleanup: break out event-related code into event.[c|h]

2020-10-25T20:59:52Z

In an effort to reduce the size of dive.h and dive.c, break out the event related functions. Moreover event-names were handled by the profile-code, collect that also in the new source files. Signed-off-by: Berthold Stoeger

Use get_n2 helper function

2020-10-05T08:17:29Z

Now, that we have this helper function that should have been introduced long ago, we can make some more expressions more idiomatic. Signed-off-by: Robert C. Helling

cleanup: fold core/divecomputer.cpp into core/device.c

2020-09-13T20:54:59Z

core/device.h was declaring a number of functions that were related to divecomputers (dcs): creating a fake dc for manually entered dives and registering / accessing dc nicknames. On could argue whether these should be lumped together, but it is what it is. However, part of that was implemented in C++/Qt code in a separate core/divecomputer.cpp file. Some function therein where only accessible to C++ and declared in core/divecomputer.h. All in all, a big mess. Let's simply combine the files and conditionally compile the C++-only functions depending on the __cplusplus define. Yes, that means turning device.c into device.cpp. A brave soul might turn the C++/Qt code into C code if they whish later on. Signed-off-by: Berthold Stoeger

cleanup: remove count_divecomputers() function

2020-09-09T00:20:09Z

There is a number_of_computers() function which does the same thing with two exceptions: 1) checks for null-dive 2) returns an unsigned int Replace calls to count_divecomputers() by calls to number_of_computers(). In one case, the return type makes a different - add a cast to int there. Ultimately, we should probably change the dc_number to signed int throughout the code. Signed-off-by: Berthold Stoeger

Increase event icon size in print mode

2020-09-03T18:46:18Z

When plotting the profile in higher resolution for export, increase the icon size in the same way. This is commented out for the mobile version as that uses printMode for profile display. Signed-off-by: Robert C. Helling Signed-off-by: Dirk Hohndel

Add an "Edit Gas Change" right-click option.

2020-08-26T14:11:49Z

This new option allows a user to select a new destination tank for an existing "Gas Change" event. This is useful when Subsurface's heuristics get tanks wrong after an import from a divecomputer. The use-case arose from sidemount divers with air-integrated transmitters as well as carrying a deco tank. Signed-off-by: Michael Werle