subsurface.git/profile-widget, branch v4.9.4

profile: properly update lastgasmix when populating events

2020-05-01T19:44:50Z

When populating the events of a profile, a pointer to the current gasmix was passed around to properly calculate isobaric_counterdiffusion. The DiveEventItem::setupToolTipString() function updated this gasmix when processing gas change events. I inadvertently broke the code when replacing gasmix-pointers by values. We could of course simply revert this part of the commit. However, the data flow was horrible anyway: for example is supposed that the setup functions were called in the correct order (i.e. DiveEventItem::setupToolTipString() is called after all other functions using the gasmix). Not exactly easy to follow. Therefore, keep passing around the gasmix as value to make it clear that the functions don't modify it. Keep the gasmix up-to-date at the caller's site in ProfileWidget2::plotDive(). Signed-off-by: Berthold Stoeger

cleanup: replace Q_ASSERT by qWarning

2020-04-30T23:55:19Z

These two Q_ASSERTs made no sense - their expression (a string literal) always evaluated to true. A qWarning() was intended here. Signed-off-by: Berthold Stoeger

profile: set empty state when there is no current dive to show

2020-04-27T20:19:31Z

The profile data was not properly cleared when not showing a dive. Fixes #2787 Reported-by: Robert C. Helling Signed-off-by: Berthold Stoeger

cleanup: move get_dc_nickname from qthelper.cpp to divecomputer.cpp

2020-04-24T17:40:12Z

1) qthelper is already huge. 2) set_dc_nickname et al. is already there. Signed-off-by: Berthold Stoeger

cleanup: turn protected into private members

2020-04-14T00:18:37Z

Some profilewidget classes hat protected members which can be made private as there is no subclassing. Signed-off-by: Berthold Stoeger

cleanup: remove protected access specifier in ProfileWidget2

2020-04-14T00:18:37Z

There were a number of protected member functions in ProfileWidget2. However no class subclassed ProfileWidget2, so this appears to have been an artifact. Therefore, make these functions private. Signed-off-by: Berthold Stoeger

profile: remove ProfileWidget2::replotEnabled

2020-04-12T17:32:58Z

The last setter was removed in the previous commit. Let's remove this complexity. Signed-off-by: Berthold Stoeger

Merge pull request #2643 from bstoeger/cylinder4

2020-04-11T18:03:05Z

First steps of cylinder-editing undo

media: move picture function from dive.c to picture.c

2020-04-10T17:53:03Z

Currently, move only those functions that do not access dive structures. Signed-off-by: Berthold Stoeger

undo: implement gas switch

2020-04-06T22:13:35Z

This is a bit hairy as - in theory - one gas switch can remove other gas switch(es) at the same timestamp. However, I did not find a way to test it. Moreover, it is not clear whether the dive-tabs are properly updated on undo/redo. Signed-off-by: Berthold Stoeger