subsurface.git/profile-widget, branch v4.9.5

profile: clear pictures when displaying empty dive

2020-05-06T20:58:09Z

Since the profile does not listen to DivePictureModel resets anymore, the pictures weren't cleared when clearing the canvas. Do this explicitly. Signed-off-by: Berthold Stoeger

undo: make picture (media) deletion undoable

2020-05-06T20:58:09Z

The code is rather complex. Firstly, we have different representations of pictures throughout the code. Secondly, this tries to do add the pictures in batches to the divepicture model and that is always rather tricky. Signed-off-by: Berthold Stoeger

undo: implement undo of setting a picture time by drag&drop

2020-05-06T20:58:09Z

Even though the functionality is seemingly trivial, this is a bit invasive, as the code has to be split into two distinct parts: 1) Post undo command 2) React to changes to the divelist Don't compile that code on mobile. Signed-off-by: Berthold Stoeger

profile: don't interpret NULL as current_dive in plotDive()

2020-05-03T21:47:49Z

ProfileWidget2::plotDive() had this weird interface, where passing in NULL as dive would mean "show current_dive". However, most callers would already pass in current_dive. Therefore, unify and always pass in current_dive if the caller wants to draw the current dive. This allows us to interpret NULL as "show empty profile". Thus, passing in current_dive when there is no current_dive simply shows an empty profile. This makes the calling code in MainWindow::selectionChanged() simpler. Signed-off-by: Berthold Stoeger

profile: use member-to-function style connect() statements

2020-05-03T21:47:49Z

This makes things compile-time instead of run-time checked. Signed-off-by: Berthold Stoeger

cleanup: remove parameter to ProfleWidget2::replot()

2020-05-03T21:47:49Z

Firstly, the parameter appears conceptually wrong, as replot suggests that the currently shown dive is replot. Secondly, the only caller that passed a parameter was passing in current_dive, which is just what happens if one doesn't pass a parameter. Therefore, change that caller (call plotDive directly) and remove the parameter. Signed-off-by: Berthold Stoeger

profile: properly update lastgasmix when populating events

2020-05-01T19:44:50Z

When populating the events of a profile, a pointer to the current gasmix was passed around to properly calculate isobaric_counterdiffusion. The DiveEventItem::setupToolTipString() function updated this gasmix when processing gas change events. I inadvertently broke the code when replacing gasmix-pointers by values. We could of course simply revert this part of the commit. However, the data flow was horrible anyway: for example is supposed that the setup functions were called in the correct order (i.e. DiveEventItem::setupToolTipString() is called after all other functions using the gasmix). Not exactly easy to follow. Therefore, keep passing around the gasmix as value to make it clear that the functions don't modify it. Keep the gasmix up-to-date at the caller's site in ProfileWidget2::plotDive(). Signed-off-by: Berthold Stoeger

cleanup: replace Q_ASSERT by qWarning

2020-04-30T23:55:19Z

These two Q_ASSERTs made no sense - their expression (a string literal) always evaluated to true. A qWarning() was intended here. Signed-off-by: Berthold Stoeger

profile: set empty state when there is no current dive to show

2020-04-27T20:19:31Z

The profile data was not properly cleared when not showing a dive. Fixes #2787 Reported-by: Robert C. Helling Signed-off-by: Berthold Stoeger

cleanup: move get_dc_nickname from qthelper.cpp to divecomputer.cpp

2020-04-24T17:40:12Z

1) qthelper is already huge. 2) set_dc_nickname et al. is already there. Signed-off-by: Berthold Stoeger