subsurface.git/profile-widget, branch v5.0.0

profile: initialize DiveEventItem::dive to null

2021-03-05T07:30:23Z

To simplify debugging, this should be initialized. Found by coverity. Signed-off-by: Berthold Stoeger

planner: pass in_planner argument to replot()

2021-02-17T15:26:55Z

To remove reliance on global state, pass an "in_planner" argument to AbstractProfilePolygonItem::replot(). Thus, calls to in_planner() can be removed. This is a bit sad, since the in_planner argument is now passed to numerous replot() reimplementations of classes derived from AbstractProfilePolygonItem. However, it is only needed for one, viz. DiveGasPressureItem. Well, perhaps in the future more features will depend on the planner mode... Signed-off-by: Berthold Stoeger

cleanup: remove function declaration

2021-02-17T15:26:55Z

AbstractProfilePolygonItem::shouldCalculateStuff()'s definition has been removed some time ago. Therefore, remove its declaration. Signed-off-by: Berthold Stoeger

planner: pass in_planner argument to decoMode()

2021-02-17T15:26:55Z

To remove reliance on global state, pass an "in_planner" argument to decoMode(). Thus, calls to in_planner() can be removed. This is a more-or-less automated change. Ultimately it would probably be better to pass the current deco-mode to the affected functions instead of calling decoMode() with an in_planner parameter. Signed-off-by: Berthold Stoeger

cleanup: remove dead code from ToolTipItem::addToolTip()

2021-02-12T19:27:01Z

There was never an icon passed to this function. Therefore, remove the parameter and the code that depends on it. Signed-off-by: Berthold Stoeger

cleanup: make ToolTipItem::addToolTip() private

2021-02-12T19:27:01Z

This was not called from anywhere else. Signed-off-by: Berthold Stoeger

cleanup: whitespace fixes in profile-widget/divetooltipitem.cpp

2021-02-12T19:27:01Z

Signed-off-by: Berthold Stoeger

profile: detect dive-mode change in profile

2021-02-06T18:00:39Z

The profile must be replotted when the dive mode changes. Weirdly, this was routed via the dive-information tab (making it inherently non-mobile compatible). Detect such a change directly in the profile. Signed-off-by: Berthold Stoeger

cleanup: constify TankItem::setData()

2021-01-20T18:01:50Z

The TankItem only displays the data. Pass pointers as const. Signed-off-by: Berthold Stoeger

cleanup: remove dive parameter from DivePlotDataModel::setDive()

2021-01-20T18:01:50Z

This was not used, probably an artifact from days long gone. Signed-off-by: Berthold Stoeger