subsurface.git/profile-widget, branch v5.0.2forked from https://github.com/subsurface/subsurfacehttps://git.tsegers.com/subsurface.git/atom?h=v5.0.22021-06-29T21:05:13Zcleanup: remove unused item in ProfileWidget2's ItemPos2021-06-29T21:05:13ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-29T19:23:04Zurn:sha1:48c2b4b1bd8c23dacc52fff48b338784d7f2520e
This is most likely an artifact from a long time ago.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
cleanup: remove dead code in ToolTipItem::refresh()2021-06-28T16:53:23ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-28T15:54:09Zurn:sha1:080834c6f228536562d6d0f9f332a8d2ad821cb5
The code was downcasting the QGraphicsScene to ProfileWidget2,
but then didn't use the result. *shrug*
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
cleanup: factor out duplicate axis-initialization code2021-06-27T17:05:20ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-15T16:16:44Zurn:sha1:248976bf11df2437aa4ceb437e79cb3a7fed27c4
The axes of the profile are setup when switching into
the "ProfileState" and also when the preferences are
changed. The same code existed twice for both cases.
Let's factor it out into a single function to avoid
future divergence and confusion.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: remove internal event-copy (fix deleting/renaming events)2021-06-05T18:29:00ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-05T07:29:41Zurn:sha1:0b190243dd4463f3c944037b8688372f9cce1c5d
The DiveEventItem had an internal copy of the event. It passed
that copy to the undo-machinery, which of course didn't work.
Simply keep a pointer to the event. All changes to a dive no
pass via the undo-machinery, which causes a reload of the profile,
so this should be safe.
Reported-by: Willem Ferguson <willemferguson@zoology.up.ac.za>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: pass axes and model to DiveEventItem on construction2021-06-05T18:29:00ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-05T07:15:51Zurn:sha1:fd2862042b1aa925bd842f512ee6260865e2f5b1
Firstly, there is no point in supporting DiveEventItems without
model and axis. Secondly, this avoid pointless position-
recalculations.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: pass event at construction time to DiveEventItem2021-06-05T18:29:00ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-05T07:05:46Zurn:sha1:c93fb83edfe4bfab6bd2c01e2c54cfe7b39f0506
There is no point in having a dive event without an event.
Let's pass the event at construction time to avoid having
to handle "invalid" events.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: remove unused function ProfileWidget2::getPrintMode()2021-06-04T15:45:32ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-04T13:19:54Zurn:sha1:4462ae5aee15d21c4dcaa04eac60288d485fe30e
The last user was removed in the previous commit.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: use printMode flag directly in DiveCartesianAxis2021-06-04T15:45:32ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-04T13:15:37Zurn:sha1:1ddb55dcad5ee91d4612941eb2eeda9415971b0f
The axis has a print-mode flag. There is no point in querying
the widget.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: remove DiveCartesianAxis::maxChanged signal2021-06-04T15:45:32ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-04T08:21:30Zurn:sha1:b2b24665e7a838cd471fe657cf847571158bd03f
The last listener was removed in 0104b0a91588.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
cleanup: strongly type DepthAxis::unitSystem2021-06-01T16:25:32ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-06-01T05:50:54Zurn:sha1:622abc5afde7b37493d46b63a99c1a9e46b86ff5
This takes an enum of units::LENGTH, therefore declare it as
such. Yes, this is kind of superfluous bike shedding, but since
we have a strongly typed language, let's use it.
On a side note, the enum should probably not be named with
all-caps.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>