subsurface.git/qt-models, branch v4.5.2

Add missing tr() implementations

2015-10-23T13:48:41Z

One specific string did not translate. First, Dirk and I (via IRC) suspected a leading space was the issue (see commit eccac1321f512d8). However, I found out that the problem was still there. A non translated string "%1 shown", when applying a filter on the divelist, and looking at a trip line. It shows always untranslated "%1 shown". Extracting to-be-translated strings from the code, I found 2 errors: Class lacks Q_OBJECT macro. This patch adds a missing tr() definition and implementation to 2 structs. Signed-off-by: Jan Mulder Signed-off-by: Dirk Hohndel

Set a cylinder if the default cylinder is bogus

2015-10-22T20:57:46Z

Apparently, it can happen that the default cylinder is not set even though same_string(prefs.default_cylinder, "") is false. Then we fall back to the 11.1l air cylinder. This should silence a warnign about "Too many gases". Signed-off-by: Robert C. Helling Signed-off-by: Dirk Hohndel

Fixing annoying compiler warning

2015-10-22T10:37:50Z

Adding { } to if clause to avoid dangling warning /Users/guidolerch/src/subsurface/qt-models/cylindermodel.cpp:117: warning: add explicit braces to avoid dangling else [-Wdangling-else] [Dirk Hohndel: combined two of Guido's patches to one that is simpler] Signed-off-by: Guido Lerch Signed-off-by: Dirk Hohndel

Always make sure the planner starts with at least one cylinder

2015-10-20T08:11:04Z

void DivePlannerPointsModel::setupCylinders() in diveplannermodel.cpp handles setting up cylinders for the planner. If there is a current dive, cylinders form that dive are copied. Otherwise the default cylinder is added and lacking that a standard size cylinder. If the current dive does not have any cylinders, we could end up without cylinders. This patch adds a test for this case and delegates to the other two sources of a cylinder in that case. Signed-off-by: Robert C. Helling Signed-off-by: Dirk Hohndel

Show correct icon when only one gasmix in the list

2015-10-19T18:45:12Z

When there is only one gasmix in the list we should show the icon that tells the user that they can't remove the last gasmix from the list. Signed-off-by: Joakim Bygdell Signed-off-by: Dirk Hohndel

Display day number in trips longer than 1 day

2015-10-19T00:37:49Z

Signed-off-by: Giorgio Marzano Signed-off-by: Dirk Hohndel

Do not show lack of coordinates as having same gps information

2015-10-09T17:50:51Z

The filter that takes care to show the dive sites that have the same gps information should not take into account dives that have no gps information. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Fix a crash when editing manually added dive

2015-10-08T23:42:27Z

I have manually added dives from an ancient version of Subsurface. Trying to edit these caused Subsurface to crash due to comparison of string of dc.model that did not exist (to a static string). And further down the execution path we were crashing as there were no samples associated with the dive. See #941 Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel

Deal with weird transifex issue involving leading space

2015-10-08T09:05:06Z

Apparently transifex drops the leading space in the translation string and then at runtime the string no longer matches. So let's just code this differently. This of course creates a new string but that new string should be the string that transifex already asks people to translate... Signed-off-by: Dirk Hohndel

Make logical block match indentation

2015-10-03T13:47:37Z

Coverity CID 1325519 Signed-off-by: Dirk Hohndel