subsurface.git/qt-models, branch v4.8.3

Core: split process_dives() in post-import and post-load versions

2018-09-23T18:50:53Z

process_dives() is used to post-process the dive table after loading or importing. The first parameter states whether this was after load or import. Especially in the light of undo, load and import are fundamentally different things. Notably, that latter should be undo-able, whereas the former is not. Therefore, as a first step to make import undo-able, split the function in two versions and remove the first parameter. It turns out the the load-version is very light. It only sets the DC nicknames and sorts the dive-table. There seems to be no reason to merge dives. Signed-off-by: Berthold Stoeger

Fix compilation problem

2018-09-14T19:25:00Z

Never commit a change you didn't test. Oh well. Sorry. Signed-off-by: Dirk Hohndel

Add Q_OBJECT macro to two more classes

2018-09-14T18:55:24Z

These also showed up as concerns when creating translation strings. Adding them thankfully didn't create new strings, but not having them potentially leads to incorrect runtime behavior. Signed-off-by: Dirk Hohndel

Desktop: buddies in the dive list

2018-09-04T22:02:07Z

As proposed in RFC #1587, now also alllow buddies to be shown in the divelist. Fixes: #1587 Signed-off-by: Jan Mulder

Cleanup: make DiveTripModel a global object

2018-09-01T14:48:43Z

DiveTripModel (the model describing the dive-list) was destroyed and recreated on every reset of the list. This seems excessive. Instead - in analogy to most other models - make it a single global object. Signed-off-by: Berthold Stoeger

Filter: sort filter items in FilterModelBase::updateList()

2018-08-31T14:48:23Z

All callers of FilterModelBase::updateList() sorted the items (except the last one). Thus we can do the sorting inside the function. Signed-off-by: Berthold Stoeger

Filter: Make FilterModelBase a proper Qt model (mostly)

2018-08-31T14:48:23Z

Since FilterModelBase now contains complex data (counts and checked), we might just as well make it a full model and keep track of the name as well. I.e. do not derive from QStringListModel but from QAbstractListModel and add the name to the item structure. Implement proper reset / add / rename semantics. This is overkill at the moment, as after all any modification the model will be reset, but ultimately it will allow us to be smarter and only update rows when needed. Signed-off-by: Berthold Stoeger

Zero initialize deco state struct

2018-08-31T13:34:44Z

Valgrind found use of some uninitialized variable (probably ds->gf_low_pressure_this_dive ), see #1614. Zero is the correct value to start with. Lacking a working version of valgrind I cannot check this actually fixes the problem. Signed-off-by: Robert C. Helling

Filter: cache number of dives fulfilling filter rules

2018-08-28T12:03:59Z

Currently, in FilterModelBase::data() the number of dives is recalculated. This happens for every mouse-over event! Calculate the number of dives only on recalculation and store the count in the items-struct. Signed-off-by: Berthold Stoeger

Whitespace: make range based for loops consistent in filtermodels.cpp

2018-08-28T12:03:59Z

Consistently use "for(item: items)" instead if "for(item : items)". Signed-off-by: Berthold Stoeger