subsurface.git/qt-models, branch v4.9.3

Cleanup: remove redundant Roles:: qualifier in maplocationmodel.cpp

2019-09-06T18:48:47Z

"Roles" is a C-style enum (i.e. not C++-style enum class). Since that means that the names spill into the outer namespace, the names themselves are prefixed with "Role". Nevertheless the code qualified the names with "Roles::". This is redundant and unnecessary. Remove this redundancy to show that we understand how the language works. Note: we could also transform the enum into an enum class and remove the "Role" prefix from the names. That would arguably be "cleaner", but then the enum doesn't auto-convert to/from int, but Qt uses int to pass the roles to functions. So let's go the simple way that avoids casting. Signed-off-by: Berthold Stoeger

Cleanup: remove includes from maplocationmodel.cpp

2019-09-06T18:48:47Z

Neither "QDebug" nor "algorithm" were necessary. Signed-off-by: Berthold Stoeger

Cleanup: remove default constructor from MapLocation

2019-09-06T18:48:47Z

Since this is no longer a Q_METATYPE, nobody will try to default construct this object. Remove the default constructor and guarantee that there will be no null divesite. Of course, the lack of default constructor means that the default argument to the "selected" member variable should be removed. Signed-off-by: Berthold Stoeger

Map: don't derive MapLocation from QObject

2019-09-06T18:48:47Z

Map location is 1) A plain value type 2) Never passed to QML Make it a simple C++ class. Signed-off-by: Berthold Stoeger

Cleanup: remove accessor functions from MapLocation

2019-09-06T18:48:47Z

Let's face it: this is a value type. No point in having Java-style getters and setters. Replace by plain old and boring member variables. Signed-off-by: Berthold Stoeger

Cleanup: remove MapLocation::coordinateChanged signal

2019-09-06T18:48:47Z

Nobody was listening for that signal. Remove it. This, quite obviously, makse the setCoordinateNoEmit() function redundant. Merge with setCoordinateNoEmit(). Signed-off-by: Berthold Stoeger

Cleanup: remove Q_PROPERTIEs from MapLocation

2019-09-06T18:48:47Z

We never dish out an object of this type to QML. It is unclear how Q_PROPERTIEs could be of any use. Signed-off-by: Berthold Stoeger

Cleanup: remove MapLocationModel::count() and the attribute count

2019-09-06T18:48:47Z

These were not used anywhere and the function was redundant [same result as rowCount()]. Signed-off-by: Berthold Stoeger

Cleanup: remove MapLocationModel::get() function

2019-09-06T18:48:47Z

It was not called anymore. Signed-off-by: Berthold Stoeger

Cleanup: remove Q_INVOKABLE from MapLocationModel::setSelected()

2019-09-06T18:48:47Z

The function does not appear to be called from QML anymore. Signed-off-by: Berthold Stoeger