subsurface.git/qt-models, branch v5.0.2

Planner: Update plan when deco parameters change

2021-05-12T08:02:47Z

This makes sure that the dive plan is updated (including the planner notes) when parameters of the dive or the planner change. This fixes a bug reported by Jay Anchor. There is a chance that by partly undoing 77a6bc6d623148, this introduces too many recalculations of the plan. But without this patch, there are definitely not enough recalculations. Reported-by: Jay Anchor Signed-off-by: Robert C. Helling

profile: remove DiveAmbPressureItem

2021-05-08T11:40:24Z

This was replaced by the tissue map in 893bea700c98. Signed-off-by: Berthold Stoeger

profile: remove DiveGFLineItem

2021-05-08T11:40:24Z

This was replaced by the tissue map in 893bea700c98. Signed-off-by: Berthold Stoeger

Planner: Update notes when not computing variations

2021-05-07T18:20:30Z

A change not to compute plan variations when not needed was too aggressive and eliminated also the signal to update the notes. Bug fixed. Reported-by: Jay Anchor Signed-off-by: Robert C. Helling

planner: split DivePlannerPointsModel::remove() in two

2021-04-02T20:53:23Z

There are two cases in this function: with and without holding the control-key. The former deletes one point, the latter all points starting with the selected point to the end. The code was interlaced making it very hard to reason about. Notably, it was buggy: with control, all points could be deleted, leading to a crash. Split the function in two versions, with their own bound checking. This produces a bit of duplicate code, which might be broken out later. Signed-off-by: Berthold Stoeger

planner: avoid starting unneeded variation thread

2021-04-02T20:53:23Z

When updating the dive profile, a thread is started to calculate plan-variations. This is done even when only editing the profile or when variation calculation is disabled by the user. The thread then exits if it shouldn't calculate the variations. Turn this around: test whether variations should be calculated before starting the thread. Signed-off-by: Berthold Stoeger

planner: remove DivePlannerPointsModel::recalc flag

2021-04-02T20:53:23Z

There was no user of that flag left. Signed-off-by: Berthold Stoeger

planner: call removeDeco() explicitly

2021-04-02T20:53:23Z

removeDeco() was called by addStop() if the recalc flag was set. If the caller didn't want to call removeDeco() it had to clear and restore the flag. Instead, call removeDeco() explicitly when needed. Signed-off-by: Berthold Stoeger

planner: don't clear recalc in DivePlannerPointsModel::clear()

2021-04-02T20:53:23Z

There are no more external users of this flag, therefore clearing that flag is a no-op. Moreover, clear the cylinders array and the preserved_until flag befor emitting the model-reset signal. Signed-off-by: Berthold Stoeger

planner: split DivePlannerPointsModel::removePoints() in two

2021-04-02T20:53:23Z

Split the function in one external version, that updates the dive profile and cylinders and one internal version, that does no recalculations. In the latter case, the caller is responsible for updating the dive. Thus, the recalculation flag-clearing can be removed from removeDeco(). Signed-off-by: Berthold Stoeger