subsurface.git/qt-ui/profile, branch v4.1

Fix another dangling pointer

2014-05-08T05:02:21Z

Same problem as the previous commit: toStdString() returns a temporary, and c_str() will return a pointer to internal data, freed at the end of the statement. So get the pointer to be strcpy'ed in the same statement. Changed to toUtf8() to be more explicit about the encoding and to avoid std::string Signed-off-by: Thiago Macieira Signed-off-by: Dirk Hohndel

Change the profile redraw logic after preferences were changed

2014-05-05T22:58:25Z

I we are showing a calculated ceiling, then we have to replot the profile after a preferences change as the gradient factors could have changed which might change a calculated ceiling. Also use the rulergraph preference instead of checking the settings directly. Fixes #511 Signed-off-by: Dirk Hohndel

Fix bug in handling of fake SAMPLE_EVENT_PO2 events

2014-05-05T16:32:13Z

In commit bcdd6192fe45 ("Show translated event names in tooltip") I was too aggressive in replacing the checking for event names with checking for event types. It turns out that we are abusing an existing event type in the planner (and use a different event name to mark the difference). By just checking for the type this now caused incorrect information to be displayed in the info box (a simply "PO2 warning" on a Suunto D9 could turn into a "Bailing out to OC" notice). The correct fix is to get our own range of SAMPLE_EVENT_xxx numbers from libdivecomputer. Once we have those, we can do this the right way. For now we just fall back to also checking the event name (which is what I wanted to get away from so translated names don't trip us up). Signed-off-by: Dirk Hohndel

Fix test for "air" in tooltip display of gaschange

2014-04-30T05:39:33Z

The "is_air()" test works when we have the gases in permille, but not in percent. In that case we can just check for He == 0 and O2 == 21. Signed-off-by: Dirk Hohndel

Show translated event names in tooltip

2014-04-30T05:38:55Z

In order for this to work we need to compare against the event type instead of the event name - which makes much more sense to do, anyway. Signed-off-by: Dirk Hohndel

Make heartrate grid less confusing

2014-04-28T19:45:42Z

Having all the grid lines in the same color made things visually confusing. To clean this up a little make the heartrate lines a light gray color. Fixes #484 Signed-off-by: Dirk Hohndel

Renaming the prefs struct members to be consistent with the QSettings.

2014-04-16T20:09:55Z

-Renaming prefs members for consistency. -Changing references of QSettings to the prefs structure instead. -Removing unused functions in pref.h were left over from an old version. -Changing the data-type of bool members to short for consistency with other members. Signed-off-by: Gehad elrobey Signed-off-by: Dirk Hohndel

Simplify code

2014-04-15T06:21:09Z

This seems like a rather obvious optimization... Signed-off-by: Dirk Hohndel

Make red ceiling work

2014-04-15T05:52:22Z

The existing code for toggling the DC reported ceiling in red or "surface color" clearly had never been tested. This seems to create a reasonably attractive implementation - not exactly what we had in the past, but good enough. Signed-off-by: Dirk Hohndel

Change some references of QSettings to the pref struct.

2014-04-11T14:21:15Z

After adding the animation member in the preference struct, it is very resonable to change these references of QSettings to the preference structure instead. Signed-off-by: Gehad elrobey Signed-off-by: Dirk Hohndel