subsurface.git/qt-ui/profile, branch v4.1.91

Save / Restore the QPainter before operations.

2014-07-18T17:14:27Z

I don't know if this fixes anything, but it is asked of us to do that by the Qt docs. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Correct usage of current_dive to displayed_dive

2014-07-18T17:09:42Z

current_dive is the selected dive, and displayed_dive is the one we are currently drawing. They are quite often the same one, but not in the case of adding a dive for example. This fixes potential null pointer dereferences in the case of a blank divelist, and makes sure we use the correct data in the case of adding and planning dives. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Hide gachange events in the first 30 seconds

2014-07-17T07:04:44Z

Back in 4.0 we hide all gaschange events during the first 30 seconds, not just gaschange events on second 0. Eg, the OSTC3 emits its gaschange event on the first sample, which can be 2, 10 or 30 seconds into the dive. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Use get_cylinder_index instead of get_gasidx

2014-07-17T07:04:32Z

Replace get_gasmix_from_event and get_gasidx with get_cylinder_index. get_cylinder_index actually knows about both types of gaschange events and the difference between them. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Add missing struct keyword in DivePlotDataModel

2014-07-17T07:04:24Z

Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Use plot_data cylinderindex instead of event data

2014-07-17T07:01:42Z

For the info box, we can't use the event data, because its not 1:1 mapped to whats in the cylinder and what we actually switched to. Use the plot_data here we already calculated what we are switching to. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Do not create a backup for Q_FOREACH container

2014-07-15T23:55:10Z

Q_FOREACH will expand and already creates a copy of the contained container, so this is just a waste of cpu cycles and also increases a tiny bit the memory consumption. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Shrink YAxis when heart rate is on display

2014-07-15T04:38:34Z

This patch makes sure that YAxis is not expanded to cover heart rate when it is displayed on profile panel. Signed-off-by: Lakshman Anumolu Signed-off-by: Dirk Hohndel

profile2: remove unused varable diveComputer

2014-07-15T01:33:57Z

Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Rename event: correctly replace event with new one

2014-07-12T19:56:03Z

I don't like that the event structure includes the variable length array. That really makes it a pain to change the name of an event (on the flip side, freeing events is easier I guess). Anyway, to correctly rename an event we need to actually remove the event from the correct dc and then add a new event with the new name. The previous code was insane (it only worked if the new name was of smaller or equal length, otherwise it had a beautiful buffer overflow). And of course we need to do this both for the current_dive and the displayed_dive. Fixes #616 Signed-off-by: Dirk Hohndel