subsurface.git/qt-ui/profile, branch v4.1.92

Code cleanup: HeartRate item was doing insane things

2014-07-23T14:51:22Z

This simplifies so much of the code that we were using to control the visibility of the HeartRate. now things are much saner. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Animation speed is a value, not a boolean

2014-07-23T14:50:03Z

This breaks compatibility with old preferences, but it's a single key and not that very important so I don't think it's a bigger issue I've renamed prefs.animation to prefs.animation_speed to denote that it's a value, and not a state. Also, fixed the places that were treating it as a state (on/off) to treat it like a correct value. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Don't plot pictures in Print mode

2014-07-23T14:48:22Z

The pictures were being plotted in print mode, the main reason for this was that when we entered print mode and had already a picture plotted, the method would return before removing them from the screen. This fixes it. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Set visibility in a saner way

2014-07-23T14:47:27Z

for some reason we did a if(true) setValue(true) else serValue(false) now we just use the value to set the value. =p Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Break really long line.

2014-07-23T14:47:23Z

Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Save / Restore the QPainter before operations.

2014-07-18T17:14:27Z

I don't know if this fixes anything, but it is asked of us to do that by the Qt docs. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Correct usage of current_dive to displayed_dive

2014-07-18T17:09:42Z

current_dive is the selected dive, and displayed_dive is the one we are currently drawing. They are quite often the same one, but not in the case of adding a dive for example. This fixes potential null pointer dereferences in the case of a blank divelist, and makes sure we use the correct data in the case of adding and planning dives. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Hide gachange events in the first 30 seconds

2014-07-17T07:04:44Z

Back in 4.0 we hide all gaschange events during the first 30 seconds, not just gaschange events on second 0. Eg, the OSTC3 emits its gaschange event on the first sample, which can be 2, 10 or 30 seconds into the dive. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Use get_cylinder_index instead of get_gasidx

2014-07-17T07:04:32Z

Replace get_gasmix_from_event and get_gasidx with get_cylinder_index. get_cylinder_index actually knows about both types of gaschange events and the difference between them. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Add missing struct keyword in DivePlotDataModel

2014-07-17T07:04:24Z

Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel