subsurface.git/qt-ui/profile, branch v4.5.4

profilewidget2.cpp: hide the heartbeat graph on an empty state

2015-12-06T20:19:26Z

Opening Subsurface for the first time with heartbeat graph visible and then immediately doing File->New shows the logo/background in the profile space while hiding everything except the heartbeat graph. This patch makes sure that the graph is hidden with everything else on an empty profile state. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Prevent gaschange tank icons from using garbage coords.

2015-12-06T17:37:07Z

Tank icons were shown at incorrect spots on the profile when the DiveEventItem object held a pointer to a struct event even after the struct event at that address had been freed. When internalEvent is a pointer to freed memory, internalEvent->time.seconds could have all kinds of crazy values, which get used in member function DiveEventItem::recalculatePos to place the tank at bad x coordinates. The DiveEventItem(s) no longer store a pointer to memory that they do not own. This way, no matter how the path of execution arrives into slot recalculatePos, we never need fear that the DiveEventItem will dereference a garbage pointer to a struct event. Fixes #968 Signed-off-by: K. Heller Signed-off-by: Dirk Hohndel

Remove unnecessary Q_INTERFACES declaration

2015-10-26T21:15:14Z

Signed-off-by: Dirk Hohndel

Use neutral color for "no SAC information"

2015-10-25T04:00:58Z

In commit 31d1d1f4217c ("Don't change pen color when for zero SAC") Robert continues to use the last SAC color (which certainly was better than switching to dark green for "extremely low SAC rate"). But I think it makes even more sense to mark it as neutral - so I picked a gray. Signed-off-by: Dirk Hohndel

Don't change pen color when for zero SAC

2015-10-23T21:50:21Z

When for individual plot entries the SAC is zero this comes from gas changes and the SAC calculation needing a bit more pressure data and not from the diver switching to freediving mode. So we shold not change the pen color on the pressure line for that but pretend we are still breathing at the previous SAC. Signed-off-by: Robert C. Helling

profilewidget2: fix line width when printing on OSX and Linux

2015-10-11T17:32:11Z

On OSX and Linux only, the cosmetic width of the QPen on profile axes does not work and is weirdly dependent on the fact if a printer is installed or not. Possible Qt bugs at hand. The same is not present on Win32. To solve the issues we add setPrintMode() in DiveCartesianAxis and call it for all instances of the class in ProfileWidget2. This patch also moves gridPen() as a private member function of PartialGasPressureAxis as it now needs to access member variables. Fixes #943 Reported-by: Willem Ferguson Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

profilewidget2: add resetZoom()

2015-10-11T17:31:25Z

resetZoom() is now a new method that is called both when 'printMode' is updated or when the dive is re-plotted. Fixes a bug where zooming in on the profile and then printing the dive has the profile at the wrong zoom level (makes the profile look smaller). Reported-by: Willem Ferguson Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Preserve profile toggle-button state zoomed_plot across sessions.

2015-10-07T07:34:47Z

Fixes #912 Signed-off-by: K. Heller Signed-off-by: Dirk Hohndel

Add refreshProfile member function to MainWindow class

2015-09-23T02:58:14Z

While the whole idea of calling these functions through the MainWindow instance is atrocious, until we change the architecture of all this refreshProfile() is a useful function to have. In order to make this cleaner to implement I allowed an argument to ProfileWidget's replot() which allows picking a specific dive. By defaulting this to 0 we get the previous behavior when calling replot() without an argument. Signed-off-by: Dirk Hohndel

Display error messages in planner

2015-08-21T17:16:06Z

After a replot, check if there is an error message to display. Signed-off-by: Robert C. Helling Signed-off-by: Dirk Hohndel