subsurface.git/qt-ui, branch v4.0.2

Remove now stale arguments to "CHANGED()" macro

2014-01-09T07:48:33Z

We now never remove units or percentage signs, and always just compare the string data, so we should remove the hacky arguments that are no longer used. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

Add and use 'string_to_fraction()' helper converter function

2014-01-09T07:48:22Z

This matches the pattern of unit conversion, and will allow us to remove all the code that uses the old complex "CHANGED()" macro that tries to remove units or percent signs. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

Add unit-aware cylinder size string parserc

2014-01-09T07:46:03Z

Whittling down on the string parsing that doesn't check user-specified units. Still need to handle temperatures (and will do percentages to match the pattern too), but this is getting us closer to always honoring user-specified units. With this you can say that you have a "10l" cylinder at "3000psi", and it will do the right thing (it's basically a 72 cuft cylinder in imperial measurements). Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

Add unit-aware conversion of pressure data

2014-01-09T01:31:19Z

This just adds (and uses) a string_to_pressure() to parse pressure units correctly when filling in cylinder pressures. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

Add a string_to_depth() helper function to match our string_to_weight one

2014-01-09T01:30:35Z

It's currently only used for the setting of the cylinder switching depth, but now that one should work with user-specified units (so you can set a max depth in feet even if you use metric, and vice versa). In the future, if we also make the unit preferences something you can pass in (with user preferences as a default argument value), we might want to use this for parsing the XML too, so that we'd honor explicit units in the XML strings. But the XML input unit preferences are not necessarily at all the same as the user preferences, so that does require us to extend the conversion functions to do possibly explicit unit preference selection. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

const'ify our strtod() helper functions

2014-01-09T01:30:25Z

The C library doesn't use const char pointers for legacy reasons (and because you *can* modify the string the end pointer points to), but let's do it in our internal implementation just because it's a nice guarantee to have. We actually used to have a non-const end pointer and replace a decimal comma with a decimal dot, but that was because we didn't have the fancy "allow commas" flags. So by using our own strtod_flags() function, we can now keep all the strings we parse read-only rather than modify them as we parse them. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

Make 'string_to_grams()' use proper type safe types

2014-01-09T01:30:18Z

Make it use 'weight_t' and hide the "grams" part inside the type. That was the whole point of the weight_t type, after all. Returning a "double" was always bogus, since we internally always do integer grams (and the function actually used "rint()" to get all the rounding right anyway). As a result, it's now called "string_to_weight()". Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

DownloadFromDCWidget: prevent possible leaks for log/dump files

2014-01-09T01:29:40Z

If the 'logfile_name' and 'dumpfile_name' were NULL we can simply strdup() them with a new value, but if there was a previous value we need to free() first. C99 6.7.8 allows us to keep said variables without the explicit NULL initialiazation. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Setting dive as 'current' when restoring selection

2014-01-09T01:28:45Z

Restoring the selection was not setting the selected dive as current, and thus, breaking keyboard navigation. Fixes #402 Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel

Add CaseInsensitivity to all of the completers.

2014-01-09T01:28:31Z

Just one of the completers had Qt::CaseInsentitive set, setting for all of them. Fixes #400 Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel