subsurface.git/qt-ui, branch v4.1

Fix another dangling pointer

2014-05-08T05:02:21Z

Same problem as the previous commit: toStdString() returns a temporary, and c_str() will return a pointer to internal data, freed at the end of the statement. So get the pointer to be strcpy'ed in the same statement. Changed to toUtf8() to be more explicit about the encoding and to avoid std::string Signed-off-by: Thiago Macieira Signed-off-by: Dirk Hohndel

Fix crash on dereferencing dangling pointers

2014-05-08T04:52:56Z

QList::first() returns a reference to an item, but that list was a temporary. The list gets destroyed at the end of the statement (the semi-colon), so we ended up keeping a reference to freed data (i.e., a dangling pointer) Signed-off-by: Thiago Macieira Signed-off-by: Dirk Hohndel

Apply the edit of trip locations

2014-05-07T22:18:59Z

This re-adds this code that got removed in a209dfbfd53 ("Multi dive edit: don't change location texts until user saves the change") Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Only mark location changed when in edit mode

2014-05-07T22:18:53Z

Otherwise the code loading a dive into the field would mark it as changed. This re-adds this code that got removed in a209dfbfd53 ("Multi dive edit: don't change location texts until user saves the change") Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Improve the color coding when editing coordinates

2014-05-07T22:17:58Z

This still gets it wrong (i.e. marks things as edited when they are not or not edited when they are) but at least they are no longer incorrectly marked as incorrectly parsed. Signed-off-by: Dirk Hohndel

Hack around a translation issue

2014-05-07T22:17:58Z

I cannot figure out how to get the hemisphere letters translated correctly in qthelper.cpp. Short term hack for now - someone who understands how this is supposed to work really needs to take a look. Signed-off-by: Dirk Hohndel

Remove spurious debug printout

2014-05-07T22:17:58Z

Signed-off-by: Dirk Hohndel

Globe: assume that we are looking at the current_dive

2014-05-07T22:17:58Z

As in commit 3870bdafee53 ("Globe: we always center on the current dive") passing in a specific dive here makes no sense - it's always about the current dive. Fixes #513 Signed-off-by: Dirk Hohndel

Globe: we always center on the current dive

2014-05-07T22:17:47Z

Simplify the API (we'll take advantage of this in the next commit). We always center the globe on the current dive, so no point in passing that dive in. Signed-off-by: Dirk Hohndel

Multi dive edit: don't change location texts until user saves the change

2014-05-07T20:15:33Z

If we keep updating the location text of all selected dives we can lose the status of which dives had the same text of the original dive and which did not (this happens if the location we are adding is identical to a selected location but adds text to the end of it). Now we only edit the other dives after we accepted the change. Signed-off-by: Dirk Hohndel