subsurface.git/qt-ui, branch v4.1.90

Rename event: correctly replace event with new one

2014-07-12T19:56:03Z

I don't like that the event structure includes the variable length array. That really makes it a pain to change the name of an event (on the flip side, freeing events is easier I guess). Anyway, to correctly rename an event we need to actually remove the event from the correct dc and then add a new event with the new name. The previous code was insane (it only worked if the new name was of smaller or equal length, otherwise it had a beautiful buffer overflow). And of course we need to do this both for the current_dive and the displayed_dive. Fixes #616 Signed-off-by: Dirk Hohndel

Fix inserting gaschange events

2014-07-12T15:04:42Z

Use a macro that works to get the current DC. Fixes #613 Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel

Lower CCR setpoint min value in planner to 0

2014-07-12T15:03:46Z

We signal a bailout to OC via setting the setpoint to zero. A setpoint between 0.2 and 0 would be really wierd, but i couldn't figure out any better way to keep the bailout deco planning. Note: The gas consumption of CCR dives are plain wrong, but this atleast lets you plan your deco for a CCR bailout plan. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Add step size in our SpinBox delegates

2014-07-12T15:03:34Z

For the Set point spinbox, it was kinda hard just stepping by the default 1.0, so setting it to step by 0.1 makes much more sense. The int SpinBox got a step size parameter for consistency. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Use doubles in DoubleSpinBoxDelegate

2014-07-12T15:03:16Z

The previous code used qreals, but it feels clearer to use doubles when the name of the class contains the word double. The performance loss of using doubles instead of floats on arm is non-existent in this case. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Don't round range for DoubleSpinBoxDelegate to int

2014-07-12T15:02:58Z

This fixes simple copy-paste error that the DoubleSpinBoxDelegate range was stored as int, thus rounding min value from 0.2 to 0. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel

Mark divelist changed when adding bookmark

2014-07-12T05:50:09Z

Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel

Printing: print depth unit in table

2014-07-12T04:59:21Z

When adding the method that includes the depth unit to the DiveItem class I realized that this was yet another implementation of our depth unit conversion. We should just call the existing helper instead. Signed-off-by: Dirk Hohndel

Printing: make table more useful

2014-07-12T04:51:44Z

Tweak font size and column widths. Signed-off-by: Dirk Hohndel

Printing: change the header to show depth / duration

2014-07-12T04:40:22Z

At least for my dives there wasn't enough space for depth and duration in the header, most likely because I made the last two columns smaller to create more space for tags and suit. With this commit the depth and doration in the header now spans two columns and easily fits. Signed-off-by: Dirk Hohndel