subsurface.git/qt-ui, branch v4.1.93

PrintLayout: fix a potential bug in the recent table print update

2014-07-25T14:23:39Z

There is a weird QPicture dependency; we need to offset a page by headingRowHeightD2, which is half the heading height. The same doesn't make sense if we are rendering the table widget directly to the printer-painter. Moving the offset inside 'pageIndexes' is less desirable. The bug itself manifests when a top margin is set on Win32, while on Linux it's more obvious. On new page start, a fixed height from the last dive on the previous page becomes visible even if the math seems correct. Offsetting both the page index and the vertical position at which the QPicture is placed fixes that. If 'table.render(&painter...)' is used the bug also goes away and our 'pageIndexes' start to make sense again, but we want to use QPicture so that the table is in vector. I don't have a good explanation why this happens! Tested on Ubuntu 12.04 and Win7. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintDialog: make "print only selected" the default option

2014-07-25T14:07:50Z

Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: vectorize the table print

2014-07-25T04:10:44Z

Use QPicture to do that. QPainter::drawPicture() requires offsetting the target QPoint's Y value by two times the headingRow height. This can be improved the hardcodding the offset when the 'pageIndexes' are calculated, but is a bit complicated. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: reduce the scope of 'pic' and 'picPainter'

2014-07-25T04:10:30Z

Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: modify the profile font size based on the #dives per page

2014-07-25T04:10:06Z

For the profile print, the number of dives per page is: divesPerRow * divesPerColumn If we have more 3, 0.6 seems optimal, while for less we can pretty much use the default scale of 1.0. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: draw the profile to a QImage only on Linux

2014-07-25T04:06:49Z

The QImage fix for the recently reported "huge-vector-lines-in-PDF-printouts" bug is only needed on Linux. For Win32 and OSx we can render to vector. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: fix the ProfilePrintModel font

2014-07-25T04:06:42Z

Fixing the font size is required, because we don't really support a dynamic row height, as the row height is set in the class constructor. 7 seems optimal for all print modes. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: disable the QPainter scaling

2014-07-25T04:06:19Z

This is wrong because we don't really need to scale. We already have the estimated page dimentions in pixels, so taking the quotient of the printer DPI and screen DPI and then scaling (probably up) our rendered widgets via the QPainter introduces blur (due to the oversampling), and a performance penalty. By rendering at the exact dimensions we ensure that the widgets are crisp at a 100% printout. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

PrintLayout: a whitespace fix

2014-07-25T04:06:05Z

Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Printing: add 1 dive per page option

2014-07-24T18:33:28Z

With this option there is an exception, which makes the notes section of the profile table occupy half the page. This way dive plans can reasonably be printed. Fixes #636 Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel