subsurface.git/qt-ui, branch v4.4.98forked from https://github.com/subsurface/subsurfacehttps://git.tsegers.com/subsurface.git/atom?h=v4.4.982015-10-03T11:19:55ZUse copy_string() to avoid potential crash2015-10-03T11:19:55ZDirk Hohndeldirk@hohndel.org2015-10-03T11:19:55Zurn:sha1:f8e9c975b78c78d1faacfbf65a1ab768bf9d136f
If the trip has no location or notes calling strdup on NULL is just a bad
idea.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Remove unused member2015-10-02T21:30:21ZDirk Hohndeldirk@hohndel.org2015-10-02T21:30:21Zurn:sha1:6b9aea1b96dce089aeff5570527f65a83ea2a190
This isn't the bug that Coverity showed, but it was found by looking at
CID 1307969
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Avoid potential uninitialized access2015-10-02T19:42:43ZDirk Hohndeldirk@hohndel.org2015-10-02T19:42:43Zurn:sha1:6b0d9adb61472866d584a11b71ac1a71753c5ca6
I don't think this could ever happen but hey, let's be sure.
Coverity CID 1307985
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Avoid potentially uninitialized member2015-10-02T19:22:55ZDirk Hohndeldirk@hohndel.org2015-10-02T19:22:55Zurn:sha1:dde82a6ba416af03749bdb23b178d8a1d57bf200
Coverity CID 1325281
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Undo/redo of dive deletion needs to handle trips as well2015-10-02T18:50:12ZDirk Hohndeldirk@hohndel.org2015-10-02T18:50:12Zurn:sha1:a94c84d5982a10cd9adfd421aed41cf159dd3303
If we delete dives that were part of a trip, that trip may get deleted as
well. So if we undo that operation we need to bring back the trip, too.
This also deals with a bug in the original code that did the delete both
in calling code (in divelistview.cpp) and in the redo function. Because of
the nature of the delete this didn't really matter but it is of course
wrong and with the new code it would in fact cause an issue.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Add support to "split" a dive with surface time in the middle2015-10-02T02:29:43ZLinus Torvaldstorvalds@linux-foundation.org2015-10-02T01:17:37Zurn:sha1:7c427dcc020064e0ea867c77ee86db6e1f4755bb
Right now this requires that
(a) the dive have only one divecomputer associated with it.
Trying to split a dive with multiple dive computers would be *much*
harder to do, since you'd have to try to line up the surface
interval between computers etc. So just don't do it after
downloading multiple dive computers for the same dive.
(b) there must be at least one minute between the sample that came up
to the surface and the sample that goes down again.
If you just peeked your head above the surface, don't try to split
things into two dives. Maybe we can relax this for freediving or
something.
also note that the split dive will only get new numbering if the dive
that was split was the very last dive in the divelist.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Avoid having uninitialized member2015-10-02T02:02:53ZDirk Hohndeldirk@hohndel.org2015-10-02T02:02:26Zurn:sha1:b80079c37f7bad67cf91d96ef7c79e87ac0801cb
Coverity CID 1325283
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Avoid NULL dereference2015-10-02T01:24:04ZDirk Hohndeldirk@hohndel.org2015-10-02T01:24:04Zurn:sha1:a51903fbb66a32b996e37e38b5634d74358a3330
Coverity CID 1325297
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Avoid memory leaks2015-10-02T01:12:14ZDirk Hohndeldirk@hohndel.org2015-10-02T01:00:38Zurn:sha1:7d8a36820d9db03956191cfe8f10087d93bf17b5
Coverity CID 1308003
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Make dive trip location edit work again.2015-10-01T22:01:34ZTomaz Canabravatomaz.canabrava@intel.com2015-10-01T21:11:03Zurn:sha1:6979ebfdae328799a5c3f8dabc82c15299d56943
:D
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>