subsurface.git/smtk-import, branch v4.8.1

Cleanup: make lastUsedDir() functions static and non-slot, respectively

2018-06-09T15:11:29Z

The lastUsedDir() functions of MainWindow and Smrtk2ssrfcWindow don't use any member-objects and are only used in their respective translation units. Therefore, remove them from the class and made of static linkage. The lastUsedImageDir() function was declared as a slog, which makes no sense. Make it a normal static function (though one might argue why it is assiociated with the DiveListView class in the first place). Signed-off-by: Berthold Stoeger

Core: introduce new subsurface-string header

2018-05-14T17:13:39Z

First small step to shrinking dive.h. Signed-off-by: Dirk Hohndel

Cleanup: consistently use qPrintable()

2018-03-14T11:55:36Z

Replace constructs of the kind s.toUtf8().data(), s.toUtf8().constData(), s.toLocal8Bit().data(), s.toLocal8Bit.constData() or qUtf8Printable(s) by qPrintable(s). This is concise, consistent and - in principle - more performant than the .data() versions. Sadly, owing to a suboptimal implementation, qPrintable(s) currently is a pessimization compared to s.toUtf8().data(). A fix is scheduled for new Qt versions: https://codereview.qt-project.org/#/c/221331/ Signed-off-by: Berthold Stoeger

smtk-import: Add smtk2ssrf.desktop to sources

2018-02-24T21:42:01Z

Without this file AppImage won't build and travisbuild.sh will fail miserably. Signed-off-by: Salvador Cuñat

Coding-style: remove superfluous parentheses

2018-02-18T03:38:52Z

Mostly replace "return (expression);" by "return expression;" and one case of "function((parameter))" by "function(parameter)". Signed-off-by: Berthold Stoeger

smtk-import: Fix error management issue

2018-02-12T04:40:23Z

In commits eccd4b993 to 8f81a22e7 global error buffer and get_error_string() func, were moved to a call back function. This patch makes smtk2ssrf suport those changes and build again. Signed-off-by: Salvador Cuñat

Introduce helper function empty_string()

2018-01-11T05:07:13Z

There are ca. 50 constructs of the kind same_string(s, "") to test for empty or null strings. Replace them by the new helper function empty_string(). Signed-off-by: Berthold Stoeger

Use QDir::exists() instead of QDir::setCurrent() to check for existence

2017-12-04T17:35:44Z

Don't change into a directory just to see if it exists. Remove unnecessary braces of one of the changed if statements. Signed-off-by: Berthold Stoeger

Use icons relative path.

2017-12-01T07:14:46Z

Icon paths are defined in one place only - application's embedded resources. Signed-off-by: Martin Měřinský

Revert "Use icons relative path."

2017-11-29T22:05:07Z

This reverts commit b0d98f6e269be9560de1b9c140855c85fecf1dd1.