subsurface.git/smtk-import, branch v4.9.3

Cleanup: move error reporting function declarations to errorhelper.h

2019-08-08T23:26:30Z

Move the declarations of the "report_error()" and "set_error_cb()" functions and the "verbose" variable to errorhelper.h. Thus, error-reporting translation units don't have to import the big dive.h header file. Signed-off-by: Berthold Stoeger

[smtk-import] fix mem leaks on site/location failure management

2019-08-02T06:58:35Z

Signed-off-by: Salvador Cuñat

[smtk-import] avoid infinite loop on index failure

2019-08-02T06:58:35Z

As Berthold points out, a failure to match the site or location index will result in an infinite loop with previous patch. With this one the loop will end after reading the last table row even if no idx is matched. But ... If we asume this situation is possible the retrieved data would be wrong, and ending the function without filling the site structure is mandatory too. Signed-off-by: Salvador Cuñat

fix site/location build issue

2019-08-02T06:58:35Z

We were assuming these tables were sorted with their indexes, but it happens to be false, under some circustances at least. Reported-by: Andreas Hagberg Signed-off-by: Salvador Cuñat

Core: dynamically resize weight table

2019-07-18T13:01:07Z

Replace the fixed-size weightsystem table by a dynamically relocated table. Reuse the table-macros used in other parts of the code. The table stores weightsystem entries, not pointers to weightsystems. Thus, ownership of the description string is taken when adding a weightsystem. An extra function adds a cloned weightsystem at the end of the table. Signed-off-by: Berthold Stoeger

Cleanup: move tag functions into own translation unit

2019-06-19T20:11:10Z

Make dive.h a bit slimmer. It's only a drop in the bucket - but at least when modifying tag functions not the *whole* application is rebuilt anymore. Signed-off-by: Berthold Stoeger

Coding style: remove Java-style function definition

2019-04-12T15:19:07Z

Remove a few cases of void fun() { ... } While touching these functions, fix a few other whitespace coding style violations. Signed-off-by: Berthold Stoeger

Dive site: set UUID only on save or load

2019-04-12T15:19:07Z

Since the UUID will be overwritten on save and is only used on save and load, set it only on save or load. For other created dive sites, leave the UUID field uninitialized. This means that the UUID will change between saves. Let's see how the git saver handles that. Signed-off-by: Berthold Stoeger

Dive site: add dive site table parameter to dive site functions

2019-04-12T15:19:07Z

To enable undo of dive site functions, it is crucial to work with different dive site tables. Therefore add a dive site table parameter to dive site functions. For now, always pass the global dive site table. Thus, this commit shouldn't alter any functionality. After this change, a simple search for dive_site_table reveals all places where the global dive site table is accessed. Signed-off-by: Berthold Stoeger

Cleanup: unconstify string argument to add_to_string()

2019-03-27T12:58:15Z

add_to_string() frees the original string that is passed in. This should therefore not be of "const char *" type, as the contents of the string *will* be modified (or more precisely: destroyed). Same for the congener smtk_concat_str(). Signed-off-by: Berthold Stoeger