subsurface.git/tests, branch v4.5.2

Add test for more GPS coordinates

2015-10-07T16:18:44Z

We really should be able to parse the coordinates that we show in our own HTML export as well as the standard Google format... both have a comma between the latitude and longitude. Signed-off-by: Dirk Hohndel

TestPlan: update known Subsurface runtimes

2015-10-06T14:18:48Z

The purpose of testing against known Subsurface runtimes is to warn (when test is run in verbose mode) if the runtime has altered. Before the next release, we should update the known Subsurface runtimes to match current behaviour, so we are alerted when we change something during the next release cycle. Signed-off-by: Rick Walsh Signed-off-by: Dirk Hohndel

TestPlan: include subsurfacestartup.h

2015-10-06T14:16:49Z

Commit 9d8b0ad introduces the copy_prefs function, and uses it to replace prefs = default_prefs. We need to include subsurfacestartup.h for it to work in testplan.cpp, otherwise TestPlan_build fails. Signed-off-by: Rick Walsh Signed-off-by: Dirk Hohndel

Correctly copy preferences

2015-10-06T09:19:43Z

When just assigning one structure to the other we copy the string pointers. If we then modify those strings in the copy, we happily free the strings of the original. And then resetting the preferences equally happily reused those strings, pointing to long since freed memory. I think what I did now is excessive for the current use case in that it copies a ton of strings that are unset in the default_prefs. But I figured this is a rarely used function and I might as well do it correctly. Also, once we implement multi user support with per user preferences we will be copying completely populated preferences around (at least that's my guess). Fixes #940 Signed-off-by: Dirk Hohndel

Add test for import, merge and renumbering

2015-10-05T15:35:09Z

Signed-off-by: Dirk Hohndel

Make sure we don't create multiple dive sites with the same uuid

2015-09-29T16:58:16Z

This shouldn't happen, but in case there is a logic error higher up in the code somewhere, this will prevent it from happening, period. If the code asks for a new dive site with a specific uuid, simply return the existing dive site with that uuid. Signed-off-by: Dirk Hohndel

TestPlan: Set VPM-B conservatism to zero

2015-09-27T16:53:46Z

The VPM-B benchmark results are all based on nominal/zero conservatism, so we should make sure we use zero conservatism in the tests. Signed-off-by: Rick Walsh Signed-off-by: Dirk Hohndel

TestPlan: Add test for repeating dive

2015-09-22T14:36:37Z

If variables were accidentally carried through from a previous calculated plan, subsequent plan could be affected. This test aims to detect if this happens. Commit 8994270 corrected such a bug. If it were reverted, this test would fail (as it should). Signed-off-by: Rick Walsh Signed-off-by: Dirk Hohndel

Git storage test: need to instantiate the window title updater class

2015-09-18T19:05:07Z

Otherwise calling the static function can cause a crash in mark_divelist_changed() Signed-off-by: Dirk Hohndel

Test case: compare DLD log with a saved one

2015-09-13T22:28:04Z

Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel