subsurface.git/tests, branch v4.6.3

Fix trailing '\r' test failure on Windows

2017-02-25T17:24:23Z

Windows implementation of fwrite changes \n to \r\n for files opened in text mode. It caused failures in TestMerge and TestParse when comparing written files against reference data. Signed-off-by: Jeremie Guichard

Improve install and test rules for Windows test execution

2017-02-25T17:24:23Z

Update install rules to create a staging_tests folder for easy deployment to test target. Update test rules for compile time testing when wine is available on build machine. Signed-off-by: Jeremie Guichard

Move CMake variables printing into a utility macro

2017-02-25T17:24:23Z

Added cmake_variables_helper.cmake providing 2 helpers - print_variable - print_all_variables Signed-off-by: Jeremie Guichard

Fix "Load/Save to cloudstorage" for non-ASCII user names

2017-02-24T09:10:22Z

On Windows that would fail because stat() doesn't deal well with our utf8 strings. Added new subsurface_stat() portability function to replace stat(). Added Windows implementation of subsurface_stat() using wstat(), with conversion to ut16 of the inputed path. Other platform implementations (linux, android) make use of the normal stat(). Added non ASCII test case in TestGitStorage::testGitStorageLocal() Signed-off-by: Jeremie Guichard

Make TestGitStorage::testGitStorageLocal parametrizable

2017-02-24T09:10:22Z

Make use of QTest "Data Driven Testing", allowing to test multiple repo base path values. Signed-off-by: Jeremie Guichard

Replace pPrintable with qUtf8Printable in TestGitStorage

2017-02-24T09:10:22Z

Update TestGitStorage to use qUtf8Printable instead of pPrintable. This ensures that non-ASCII chars are utf8 encoded before calling internal functions. In windows case pPrintable returns other codepoint that depends on system settings. Signed-off-by: Jeremie Guichard

Use SUBSURFACE_TEST_DATA definition to point to test data dir

2017-02-24T09:10:22Z

Update tests with a (compile time) option SUBSURFACE_TEST_DATA, pointing to test data base path. It is needed for cross compilation cases. SUBSURFACE_TEST_DATA is set to SUBSURFACE_SOURCE by default, or configurable via cmake option -DSUBSURFACE_TEST_DATA="...". Signed-off-by: Jeremie Guichard

Simple test case for merging dives

2017-02-22T02:22:56Z

We do some merging in a couple of the other tests as well, but the idea is to have specific test cases that exercise our merge logic. This one starts simple. Merge a dive with some valid info with a second one that has less data filled. And then try it in both possible orders. It shows a few potential problems. Signed-off-by: Dirk Hohndel

Test for basic image handling

2017-02-21T21:14:56Z

This tests adding image files to dives including hashing and evaluating exif data. Signed-off-by: Robert C. Helling

Fix typo in saturation/desatureation rates

2017-02-19T23:29:40Z

This patch eliminates the difference between the saturation and desaturation rates. This was probably once meant as a conservative measure but the desaturation rate was increased rather than the saturation rate (which is probably a typo, as reported by Stefan). Since there is no good basis for this anyway, this patch sets both factors to 1.0 (and if accepted the whole factor business should be removed). This makes our deco times slightly longer. But in the past, we had introduced a 1.2% fudge factor in the critical radius calculation to add conservatism and match the benchmark better. Removing this fudge factor brings us close to the benchmarks. Expected test values updated. Reported-by: Stefan Signed-off-by: Robert C. Helling