subsurface.git/tests, branch v4.7.8

CSV import/export: Sort parameter list and add comment

2018-03-19T18:59:58Z

Signed-off-by: Stefan Fuchs

Cleanup: introduce copy_qstring() function

2018-03-14T11:55:36Z

strdup(qPrintable(s)) and copy_string(qPrintable(s)) were such common occurrences that they seem worthy of a short helper-function. Signed-off-by: Berthold Stoeger

Cleanup: consistently use qPrintable()

2018-03-14T11:55:36Z

Replace constructs of the kind s.toUtf8().data(), s.toUtf8().constData(), s.toLocal8Bit().data(), s.toLocal8Bit.constData() or qUtf8Printable(s) by qPrintable(s). This is concise, consistent and - in principle - more performant than the .data() versions. Sadly, owing to a suboptimal implementation, qPrintable(s) currently is a pessimization compared to s.toUtf8().data(). A fix is scheduled for new Qt versions: https://codereview.qt-project.org/#/c/221331/ Signed-off-by: Berthold Stoeger

Cleanup: Remove hash field from picture-structure

2018-03-05T16:04:57Z

The hash field in the picture-structure was in principle non-operational. It was set on loading, but never actually changed. The authoritative hash comes from the filename->hash map. Therefore, make this explicit by removing the hash field from the picture structure. Instead of filling the picture structure on loading, add the hash directly to the filename->hash map. This is done in the register_hash() function, which does not overwrite old entries. I.e. the local hash has priority over the save-file. This policy might be refined in the future. Signed-off-by: Berthold Stoeger

Cleanup: Fold add_hash() call into learnHash() function

2018-03-05T16:04:57Z

learnHash() was always called in conjunction with add_hash(). The pattern was that a local filename and a hash were connected in the hash-to-filename and the filename-to-hash maps. Then, the original picture-filename or url were registered in the filename-to-hash map. This commit changes learnHash() to take three parameters (original-filename, local-filename and hash) and do all of the above. The new code is simpler because no dummy picture struct has to be generated in DiveListView::loadImageFromURL(). The tests were extended to check for all hash<->filename associations. Signed-off-by: Berthold Stoeger

Cleanup: Don't store hash in picture struct in learnHash()

2018-03-05T16:04:57Z

learnHash() is called either on a local picture structure [DiveListView::loadImageFromURL()] or on a cloned picture structure [ImageDownloader::saveImage()]. In neither case the picture structure is passed to the frontend. Therefore, storing the new hash in the picture struct is not necessary. Signed-off-by: Berthold Stoeger

Parameter size needs to be increased for test

2018-01-08T04:06:12Z

Signed-off-by: Miika Turkia

Update DL7 tests to current import

2018-01-08T04:06:12Z

As we now parse dives without profile, we get 2 more dives from the sample log import (3 in total). And naturally also the resulting XML to compare against needs to be updated. Signed-off-by: Miika Turkia

Compare DL7 import to saved conversion

2018-01-08T04:06:12Z

Signed-off-by: Miika Turkia

Add test for DL7 import

2018-01-08T04:06:12Z

Signed-off-by: Miika Turkia