subsurface.git/tests, branch v4.9.4

cleanup: move dive_table from dive.h to divelist.h

2020-05-01T16:42:31Z

This allows us to decouple dive.h and divelist.h, a small step in include disentangling. Signed-off-by: Berthold Stoeger

move GitHub url to the Subsurface org

2020-04-26T23:36:30Z

Instead of using the Subsurface-divelog user on GitHub, we now use an org that was generously donated to us. Signed-off-by: Dirk Hohndel

cleanup: move clearing of device nodes to clear_dive_file_data()

2020-04-24T17:40:12Z

It makes no sense to keep the device nodes if all the other data is cleared. Let's do this automatically and not explicitly. This ensures that the function is also called on mobile. Currently it was only called on desktop. Weirdly, the parser-tests were expecting that the device nodes were not reset by clear_dive_file_data() and therefore divecomputers were accumulating in the test results. Thus, the additional computers had to be removed from the expected test results. Signed-off-by: Berthold Stoeger

desktop: remove user survey

2020-04-19T21:27:54Z

We have never made good use of the results. Let's just remove it. Signed-off-by: Dirk Hohndel

testing: re-enable TestGitStorage

2020-04-15T14:58:10Z

Signed-off-by: Dirk Hohndel

testing/git-storage: alternative random number generation for Qt 5.9

2020-04-15T14:58:10Z

We still need to support Qt 5.9 for Ubuntu 18.04 / Bionic. This uses deprecated calls to qrand() - but then qrand() wasn't deprecated in 5.9. Signed-off-by: Dirk Hohndel

testing/git-storage: fairly fundamental rewrite of the storage test

2020-04-15T14:58:10Z

The old test was broken in many ways and kept failing for a number of reasons. Some of them were addressed in the previous commits (the missing HEAD ref being the main one), the other one was that the tests kept stepping on top of each other - as were potentially random users or reviewers using the 'universal' test account. This uses a random one of ten dedicated test accounts, and on top of that uses a random branch name (instead of the fixed email address associated with the account). This also rewrites several of the tests dealing with offline changes to correctly model going offline (but keeps one that directly writes to the local cache). Finally this change also tries to do a much better job cleaning up after itself and not leaving data behind the the next run could stumble over. Signed-off-by: Dirk Hohndel

media: move picture function from dive.c to picture.c

2020-04-10T17:53:03Z

Currently, move only those functions that do not access dive structures. Signed-off-by: Berthold Stoeger

cleanup: don't compile subsurface-helper.cpp for tests

2020-03-31T15:49:12Z

It is unclear why the subsurface-helper.cpp file was linked with the tests. In any case, it led to comlicated ifdef-ery, so let's remove that for now and readd later if the need arises. Signed-off-by: Berthold Stoeger

Grammar: replaces 'indexes' by 'indices'

2020-03-11T15:26:30Z

Grammar-nazi ran git grep -l 'indexes' | xargs sed -i '' -e 's/indexes/indices/g' to prevent future wincing when reading the source code. Unfortunatly, Qt itself is infected as in QModelIndexList QItemSelection::indexes() const Signed-off-by: Robert C. Helling