subsurface.git/tests, branch v4.9.8

tests: don't fail if TestGitStorage can reach the server

2020-10-27T02:27:03Z

Signed-off-by: Dirk Hohndel

cleanup: split out divecomputer functions from dive.c

2020-10-25T20:59:52Z

Since dive.c is so huge, split out divecomputer-related functions into divecomputer.[c|h], sample.[c|h] and extradata.[c|h]. This does not give huge compile time improvements, since struct dive contains a struct divecomputer and therefore dive.h has to include divecomputer.h. However, it make things distinctly more clear. Signed-off-by: Berthold Stoeger

cleanup: break out event-related code into event.[c|h]

2020-10-25T20:59:52Z

In an effort to reduce the size of dive.h and dive.c, break out the event related functions. Moreover event-names were handled by the profile-code, collect that also in the new source files. Signed-off-by: Berthold Stoeger

cleanup: remove unsaved_changes() test in testrenumber.cpp

2020-10-25T20:59:04Z

Unsaved changes are now kept track by the undo-system. No need to test for this function when directly modifying the core data structures. Signed-off-by: Berthold Stoeger

tests: move TestGitStorage to its own test config

2020-10-24T22:22:37Z

This way 'make check' doesn't execute TestGitStorage anymore. Signed-off-by: Dirk Hohndel

devices: add devices in Command::importTable()

2020-10-24T16:51:37Z

Add a device_table parameters to Command::importTable() and add_imported_dives(). The content of this table will be added to the global device list (respectively removed on undo). This is currently a no-op, as the parser doesn't yet fill out the device table, but adds devices directly to the global device table. Signed-off-by: Berthold Stoeger

parser: add device_table to parser state

2020-10-24T16:51:37Z

If we want to avoid the parsers to directly modify global data, we have to provide a device_table to parse into. This adds such a state and the corresponding function parameters. However, for now this is unused. Adding new parameters is very painful and this commit shows that we urgently need a "struct divelog" collecting all those tables! Signed-off-by: Berthold Stoeger

parser: replace params[] code by new xml_params struct

2020-10-24T01:17:02Z

This fixes a load of memory holes, and makes the code (hopefully) more readable. Signed-off-by: Berthold Stoeger

filter: remove filter_preset_table_t

2020-10-17T16:04:20Z

We used a typedef "filter_preset_table_t" for the filter preset table, because it is a "std::vector". However, that is in contrast to all the other global tables (dives, trips, sites) that we have. Therefore, turn this into a standard struct, which simply inherits from "std::vector". Note that while inheriting from std::vector<> is generally not recommended, it is not a problem here, because we don't modify it in any shape or form. Signed-off-by: Berthold Stoeger

filter: load filter presets from XML files

2020-09-29T23:13:03Z

This is a bit painful: since we don't want to modify the filter presets when the user imports (as opposed to opens) a log, we have to provide a table where the parser stores the presets. Calling the parser is getting quite unwieldy, since many tables are passed. We probably should introduce a structure representing a full log-book at one point, which collects all the things that are saved to the log. Apart from that, this is simply the counterpart to saving to XML. The interpretation of the string data is performed by core functions, not the parser itself to avoid code duplication with the git parser. Signed-off-by: Berthold Stoeger