change the key from const char * to QByteArray

if trGettext() gets called with a *text that resides
in the stack, the QHash will return incorrect values after
the second call of trGettext() with that *text.

Example (assuming nothing has been translated):

void func(const char *text) {
        char *translated = trGettext(text);
        doSomethingWith(translated);
}

func("foo"); (1)
func("bar"); (2)

(1) *translated is "foo"
(2) *translated should be "bar" but is "foo" because
    the key (const char*) points to the value "foo"
    which has been set in the previous call (1).

Signed-off-by: Maximilian Güntner <maximilian.guentner@gmail.com>

2 files changed, 2 insertions, 2 deletions

diff --git a/gettextfromc.cpp b/gettextfromc.cpp
index 1730b52b0..c3b822ff5 100644
--- a/gettextfromc.cpp
+++ b/gettextfromc.cpp
@@ -4,7 +4,7 @@
 
 const char *gettextFromC::trGettext(const char *text)
 {
-	QByteArray &result = translationCache[text];
+	QByteArray &result = translationCache[QByteArray(text)];
 	if (result.isEmpty())
 		result = tr(text).toUtf8();
 	return result.constData();
diff --git a/gettextfromc.h b/gettextfromc.h
index 19f02fc96..6b5f7b184 100644
--- a/gettextfromc.h
+++ b/gettextfromc.h
@@ -12,7 +12,7 @@ public:
 	static gettextFromC *instance();
 	const char *trGettext(const char *text);
 	void reset(void);
-	QHash <const char *, QByteArray> translationCache;
+	QHash <QByteArray , QByteArray> translationCache;
 };
 
 #endif // GETTEXTFROMC_H