summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Tomaz Canabrava <tomaz.canabrava@gmail.com>2016-08-28 20:20:53 -0300
committerGravatar Dirk Hohndel <dirk@hohndel.org>2016-08-28 20:01:41 -0700
commit1b074838308b6377af1461c4bd69028c193edd17 (patch)
treef10d050d7422478aa34a13c3a33c44623af9f0b2
parent3dce5de12ddbf310ed047227f3470d478b505540 (diff)
downloadsubsurface-1b074838308b6377af1461c4bd69028c193edd17.tar.gz
Settings update: Fix git_local_only loading
Thanks to the unittesting. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
-rw-r--r--core/subsurface-qt/SettingsObjectWrapper.cpp3
-rw-r--r--tests/testpreferences.cpp10
2 files changed, 13 insertions, 0 deletions
diff --git a/core/subsurface-qt/SettingsObjectWrapper.cpp b/core/subsurface-qt/SettingsObjectWrapper.cpp
index 55670eb22..a329e0452 100644
--- a/core/subsurface-qt/SettingsObjectWrapper.cpp
+++ b/core/subsurface-qt/SettingsObjectWrapper.cpp
@@ -1111,6 +1111,9 @@ void CloudStorageSettings::setGitLocalOnly(bool value)
{
if (value == prefs.git_local_only)
return;
+ QSettings s;
+ s.beginGroup("CloudStorage");
+ s.setValue("git_local_only", value);
prefs.git_local_only = value;
emit gitLocalOnlyChanged(value);
}
diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp
index 652cf6f1d..3148bffea 100644
--- a/tests/testpreferences.cpp
+++ b/tests/testpreferences.cpp
@@ -30,6 +30,16 @@ void TestPreferences::testPreferences()
TEST(pref->cloud_storage->baseUrl(), QStringLiteral("test_one"));
pref->cloud_storage->setBaseUrl("test_two");
TEST(pref->cloud_storage->baseUrl(), QStringLiteral("test_two"));
+
+ pref->cloud_storage->setEmail("tomaz@subsurface.com");
+ TEST(pref->cloud_storage->email(), QStringLiteral("tomaz@subsurface.com"));
+ pref->cloud_storage->setEmail("tomaz@gmail.com");
+ TEST(pref->cloud_storage->email(), QStringLiteral("tomaz@gmail.com"));
+
+ pref->cloud_storage->setGitLocalOnly(true);
+ TEST(pref->cloud_storage->gitLocalOnly(), true);
+ pref->cloud_storage->setGitLocalOnly(false);
+ TEST(pref->cloud_storage->gitLocalOnly(), false);
}
QTEST_MAIN(TestPreferences)