summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Linus Torvalds <torvalds@linux-foundation.org>2011-09-01 17:13:39 -0700
committerGravatar Linus Torvalds <torvalds@linux-foundation.org>2011-09-01 17:13:39 -0700
commit5001ab66cba885411e9ee4e8c701688b4928ab1d (patch)
tree11194c79b96a974cb5f43e5e0500a197a8064ee3
parent1376712f0bc952e33a42121570c64add6a2a9446 (diff)
downloadsubsurface-5001ab66cba885411e9ee4e8c701688b4928ab1d.tar.gz
Teach the date parser to also parse the international standard date format
The standard way to write a date is yyyy-mm-dd, which is unambiguous and sorts correctly. We parsed that right in the 'datetime' case, but not in the normal date case. And we do want to use that in our output format, exactly because it's standard. And also parse 'duration' for the dive duration. It's what we use when saving, it just so happened that we ended up not parsing it right, but then picking it up from the samples instead. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--parse-xml.c17
1 files changed, 15 insertions, 2 deletions
diff --git a/parse-xml.c b/parse-xml.c
index ea568f740..6c93ad1a5 100644
--- a/parse-xml.c
+++ b/parse-xml.c
@@ -106,14 +106,25 @@ static void divedate(char *buffer, void *_when)
{
int d,m,y;
time_t *when = _when;
+ int success = 0;
+ success = tm.tm_sec | tm.tm_min | tm.tm_hour;
if (sscanf(buffer, "%d.%d.%d", &d, &m, &y) == 3) {
tm.tm_year = y;
tm.tm_mon = m-1;
tm.tm_mday = d;
- if (tm.tm_sec | tm.tm_min | tm.tm_hour)
- *when = utc_mktime(&tm);
+ } else if (sscanf(buffer, "%d-%d-%d", &y, &m, &d) == 3) {
+ tm.tm_year = y;
+ tm.tm_mon = m-1;
+ tm.tm_mday = d;
+ } else {
+ fprintf(stderr, "Unable to parse date '%s'\n", buffer);
+ success = 0;
}
+
+ if (success)
+ *when = utc_mktime(&tm);
+
free(buffer);
}
@@ -396,6 +407,8 @@ static void try_to_fill_dive(struct dive *dive, const char *name, char *buf)
return;
if (MATCH(".meandepth", depth, &dive->meandepth))
return;
+ if (MATCH(".duration", duration, &dive->duration))
+ return;
if (MATCH(".divetime", duration, &dive->duration))
return;
if (MATCH(".divetimesec", duration, &dive->duration))