summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-02-26 11:03:57 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-02-28 07:27:10 -0800
commit0893f87beb943ed8f5872aef18274f456b0c51ca (patch)
tree1d1405f39a60ef87c3e300ec3210e0058d613ef5
parentf6957c54afaa58eab0b57127ac1f31389dfd35e1 (diff)
downloadsubsurface-0893f87beb943ed8f5872aef18274f456b0c51ca.tar.gz
Cleanup: uninline get_dive_site_by_uuid
There seems to be no compelling reason to have this function inlined. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--core/divesite.c10
-rw-r--r--core/divesite.h11
2 files changed, 11 insertions, 10 deletions
diff --git a/core/divesite.c b/core/divesite.c
index 25ec82ef3..a04d69f23 100644
--- a/core/divesite.c
+++ b/core/divesite.c
@@ -10,6 +10,16 @@
struct dive_site_table dive_site_table;
+struct dive_site *get_dive_site_by_uuid(uint32_t uuid)
+{
+ int i;
+ struct dive_site *ds;
+ for_each_dive_site (i, ds)
+ if (ds->uuid == uuid)
+ return get_dive_site(i);
+ return NULL;
+}
+
/* there could be multiple sites of the same name - return the first one */
struct dive_site *get_dive_site_by_name(const char *name)
{
diff --git a/core/divesite.h b/core/divesite.h
index 971eb6711..01c1f82f3 100644
--- a/core/divesite.h
+++ b/core/divesite.h
@@ -42,16 +42,7 @@ static inline struct dive_site *get_dive_site(int nr)
#define for_each_dive_site(_i, _x) \
for ((_i) = 0; ((_x) = get_dive_site(_i)) != NULL; (_i)++)
-static inline struct dive_site *get_dive_site_by_uuid(uint32_t uuid)
-{
- int i;
- struct dive_site *ds;
- for_each_dive_site (i, ds)
- if (ds->uuid == uuid)
- return get_dive_site(i);
- return NULL;
-}
-
+struct dive_site *get_dive_site_by_uuid(uint32_t uuid);
void dive_site_table_sort();
struct dive_site *alloc_or_get_dive_site(uint32_t uuid);
int nr_of_dives_at_dive_site(struct dive_site *ds, bool select_only);