diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-06-15 20:22:07 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-06-16 04:02:47 -0700 |
| commit | 3f012f4bdbfc70cae16a40f4a22f3d635c2b0a4a (patch) | |
| tree | 15a14a1205c9b3a327617ad52830b37297821a55 | |
| parent | fed2a283b211fc7156678a118dd091fa2773ae76 (diff) | |
| download | subsurface-3f012f4bdbfc70cae16a40f4a22f3d635c2b0a4a.tar.gz | |
Cleanup: Don't clear WA_QuitOnClose attribute on dialogs
According to Qt's documentation, the application exits if all windows
with the WA_QuitOnClose attribute are closed. This attribute was cleared
for three dialogs. This seems not necessary because:
1) The application can't be closed as long as the modal dialog is shown.
2) The flag only concerns primary windows, which these are not.
See: http://doc.qt.io/qt-5/qguiapplication.html#quitOnLastWindowClosed-prop
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
| -rw-r--r-- | desktop-widgets/divecomputermanagementdialog.cpp | 1 | ||||
| -rw-r--r-- | desktop-widgets/diveshareexportdialog.cpp | 1 | ||||
| -rw-r--r-- | desktop-widgets/subsurfacewebservices.cpp | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/desktop-widgets/divecomputermanagementdialog.cpp b/desktop-widgets/divecomputermanagementdialog.cpp index 0835abd6c..5a54bc953 100644 --- a/desktop-widgets/divecomputermanagementdialog.cpp +++ b/desktop-widgets/divecomputermanagementdialog.cpp @@ -28,7 +28,6 @@ void DiveComputerManagementDialog::init() DiveComputerManagementDialog *DiveComputerManagementDialog::instance() { static DiveComputerManagementDialog *self = new DiveComputerManagementDialog(MainWindow::instance()); - self->setAttribute(Qt::WA_QuitOnClose, false); return self; } diff --git a/desktop-widgets/diveshareexportdialog.cpp b/desktop-widgets/diveshareexportdialog.cpp index c106cdc75..2689eaca8 100644 --- a/desktop-widgets/diveshareexportdialog.cpp +++ b/desktop-widgets/diveshareexportdialog.cpp @@ -32,7 +32,6 @@ void DiveShareExportDialog::UIDFromBrowser() DiveShareExportDialog *DiveShareExportDialog::instance() { static DiveShareExportDialog *self = new DiveShareExportDialog(MainWindow::instance()); - self->setAttribute(Qt::WA_QuitOnClose, false); self->ui->txtResult->setHtml(""); self->ui->buttonBox->setStandardButtons(QDialogButtonBox::Cancel); return self; diff --git a/desktop-widgets/subsurfacewebservices.cpp b/desktop-widgets/subsurfacewebservices.cpp index db0c80832..d5a6f005f 100644 --- a/desktop-widgets/subsurfacewebservices.cpp +++ b/desktop-widgets/subsurfacewebservices.cpp @@ -691,7 +691,6 @@ out: DivelogsDeWebServices *DivelogsDeWebServices::instance() { static DivelogsDeWebServices *self = new DivelogsDeWebServices(MainWindow::instance()); - self->setAttribute(Qt::WA_QuitOnClose, false); return self; } |