Just use strdup

In commit 272f85bb2444 ("Fix silly crash") I indeed fixed the crash, but I
also broke the code. Now a broken userid might end upsaved in the data
file. Oops.

This should be correct now.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 1 insertions, 7 deletions

diff --git a/dive.c b/dive.c
index c958478bb..9972212aa 100644
--- a/dive.c
+++ b/dive.c
@@ -2505,7 +2505,6 @@ timestamp_t get_times()
 	return dive->when;
 }
 
-#define MAX_USERID_SIZE 32
 void set_save_userid_local(short value)
 {
 	prefs.save_userid_local = value;
@@ -2513,13 +2512,8 @@ void set_save_userid_local(short value)
 
 void set_userid(char *rUserId)
 {
-	prefs.userid = (char *)malloc(MAX_USERID_SIZE + 1);
-	if (prefs.userid && rUserId) {
-		strncpy(prefs.userid, rUserId, MAX_USERID_SIZE);
-		prefs.userid[MAX_USERID_SIZE] = 0;
-	}
+	prefs.userid = strdup(rUserId);
 }
-#undef MAX_USERID_SIZE
 
 int average_depth(struct diveplan *dive)
 {