diff options
| author |  Tomaz Canabrava <tcanabrava@kde.org> | 2013-12-24 09:38:35 -0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2013-12-24 07:23:10 -0800 |
| commit | 6925d13aa499b246c405687436b70d691eabe6fa (patch) | |
| tree | ab549ce56434ad995d6b87cea9457016ffc21ac2 | |
| parent | 03a01efdcb536ab2e123acf5f7f69b886f5632cf (diff) | |
| download | subsurface-6925d13aa499b246c405687436b70d691eabe6fa.tar.gz | |
Rework foreach for a faster iteration.
The old code used a QString instead of a const QString&, wich
mean that each foreach step the string was copied.
added a break on the if-found-true to stop the foreach, since
we already found it.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
| -rw-r--r-- | qt-ui/globe.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/qt-ui/globe.cpp b/qt-ui/globe.cpp index e0f94bbd5..cab24ba4a 100644 --- a/qt-ui/globe.cpp +++ b/qt-ui/globe.cpp @@ -30,12 +30,15 @@ GlobeGPS::GlobeGPS(QWidget* parent) : MarbleWidget(parent), loadedDives(0), edit // if not, check if they are in a known location MapThemeManager mtm; QStringList list = mtm.mapThemeIds(); - QString theme, subsurfaceDataPath; + QString subsurfaceDataPath; QDir marble; bool foundGoogleMap = false; - Q_FOREACH(theme, list) - if (theme == "earth/googlesat/googlesat.dgml") + Q_FOREACH(const QString& theme, list){ + if (theme == "earth/googlesat/googlesat.dgml"){ foundGoogleMap = true; + break; + } + } if (!foundGoogleMap) { subsurfaceDataPath = getSubsurfaceDataPath("marbledata"); if (subsurfaceDataPath != "") { |