diff options
| author |  Dirk Hohndel <dirk@hohndel.org> | 2020-07-14 10:25:46 -0700 |
|---|---|---|
| committer | Dirk Hohndel <dirk@hohndel.org> | 2020-07-14 10:57:10 -0700 |
| commit | 4ec62441c172958156e36013f9dbf71e18a51dd1 (patch) | |
| tree | 5f3e610aaf09c8aeaf9fe8c1c5c5acf950a7d7d5 | |
| parent | a4295a3e9f87b5eb38c1de8637ace7f1a2210030 (diff) | |
| download | subsurface-4ec62441c172958156e36013f9dbf71e18a51dd1.tar.gz | |
mobile/download: don't allow download without connection set
It appears that multi line attributes silently fail. Without this change, the Download
button is enabled if vendor and product are chosen, even if there isn't a connection
selected. With this change (having all three conditions on the same line) the code
works as expected.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
| -rw-r--r-- | mobile-widgets/qml/DownloadFromDiveComputer.qml | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/mobile-widgets/qml/DownloadFromDiveComputer.qml b/mobile-widgets/qml/DownloadFromDiveComputer.qml index 314b887d0..012829b76 100644 --- a/mobile-widgets/qml/DownloadFromDiveComputer.qml +++ b/mobile-widgets/qml/DownloadFromDiveComputer.qml @@ -320,8 +320,7 @@ Kirigami.Page { TemplateButton { id: download text: qsTr("Download") - enabled: comboVendor.currentIndex != -1 && comboProduct.currentIndex != -1 && - comboConnection.currentIndex != -1 + enabled: comboVendor.currentIndex != -1 && comboProduct.currentIndex != -1 && comboConnection.currentIndex != -1 onClicked: { text = qsTr("Retry") |