diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-07-17 15:58:26 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-07-19 21:44:13 -0700 |
| commit | 94521c9958f5416311318826450825fcbaede4ce (patch) | |
| tree | 725dbf97b3feca84b8b3a67072668bacfbea9692 | |
| parent | 726d08c2f71920acd8e5cc9b2d6850d1249466aa (diff) | |
| download | subsurface-94521c9958f5416311318826450825fcbaede4ce.tar.gz | |
Cleanup: remove bogus mark_divelist_changed() calls
The parsers / downloaders parse into a separate table and do
not directly change the divelist. Therefore, they shouldn't
call mark_divelist_changed().
Likewise split_dive_at() doesn't modify the dive list and
therefore shouldn't call this function.
Calling the function has the unwanted side-effect that undoing
the change will not clear the *-symbol in the title of the
main window.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
| -rw-r--r-- | core/cochran.c | 1 | ||||
| -rw-r--r-- | core/dive.c | 2 | ||||
| -rw-r--r-- | core/libdivecomputer.c | 1 | ||||
| -rw-r--r-- | core/liquivision.c | 1 | ||||
| -rw-r--r-- | core/ostctools.c | 1 | ||||
| -rw-r--r-- | core/uemis-downloader.c | 2 |
6 files changed, 0 insertions, 8 deletions
diff --git a/core/cochran.c b/core/cochran.c index e46f95b35..14ee65fcb 100644 --- a/core/cochran.c +++ b/core/cochran.c @@ -787,7 +787,6 @@ static void cochran_parse_dive(const unsigned char *decode, unsigned mod, } record_dive_to_table(dive, table); - mark_divelist_changed(true); free(buf); } diff --git a/core/dive.c b/core/dive.c index 04247a682..fb1159564 100644 --- a/core/dive.c +++ b/core/dive.c @@ -3195,8 +3195,6 @@ static int split_dive_at(const struct dive *dive, int a, int b, struct dive **ou d2->number = 0; } - mark_divelist_changed(true); - *out1 = d1; *out2 = d2; return nr; diff --git a/core/libdivecomputer.c b/core/libdivecomputer.c index a870317b1..7c3356f6f 100644 --- a/core/libdivecomputer.c +++ b/core/libdivecomputer.c @@ -826,7 +826,6 @@ static int dive_cb(const unsigned char *data, unsigned int size, } record_dive_to_table(dive, devdata->download_table); - mark_divelist_changed(true); return true; error_exit: diff --git a/core/liquivision.c b/core/liquivision.c index 01e9843c1..e5b3ea48b 100644 --- a/core/liquivision.c +++ b/core/liquivision.c @@ -424,7 +424,6 @@ static void parse_dives(int log_version, const unsigned char *buf, unsigned int // End dive record_dive_to_table(dive, table); dive = NULL; - mark_divelist_changed(true); // Advance ptr for next dive ptr += ps_ptr + 4; diff --git a/core/ostctools.c b/core/ostctools.c index 21c58e537..4ebb85015 100644 --- a/core/ostctools.c +++ b/core/ostctools.c @@ -190,7 +190,6 @@ void ostctools_import(const char *file, struct dive_table *divetable, struct tri add_extra_data(&ostcdive->dc, "Serial", ostcdive->dc.serial); } record_dive_to_table(ostcdive, divetable); - mark_divelist_changed(true); sort_dive_table(divetable); close_out: diff --git a/core/uemis-downloader.c b/core/uemis-downloader.c index 5ad6b92be..08fa44542 100644 --- a/core/uemis-downloader.c +++ b/core/uemis-downloader.c @@ -1018,14 +1018,12 @@ static bool process_raw_buffer(device_data_t *devdata, uint32_t deviceid, char * if (done && ++bp < endptr && *bp != '{' && strstr(bp, "{{")) { done = false; record_dive_to_table(dive, devdata->download_table); - mark_divelist_changed(true); dive = uemis_start_dive(deviceid); } } if (is_log) { if (dive->dc.diveid) { record_dive_to_table(dive, devdata->download_table); - mark_divelist_changed(true); } else { /* partial dive */ free(dive); free(buf); |