diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2020-10-04 21:24:01 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2020-10-05 12:39:16 -0700 |
| commit | 468eb7ef33443dcc303aaf87e4d33302053238fa (patch) | |
| tree | 1faa42540207c013c2c6e22cc094ad54def822de | |
| parent | 4b4a117f966c16824e6980ecc835e30e4cb4db42 (diff) | |
| download | subsurface-468eb7ef33443dcc303aaf87e4d33302053238fa.tar.gz | |
clenup: remove bogus connect statement.
In OstcFirmwareCheck::saveOstcFirmware() we find the connect() call
connect(dialog, SIGNAL(finished(int)), config, SLOT(dc_close()));
whereby "config" is of the type "ConfigureDiveComputer".
However, the function signature of ConfigureDiveComputer::dc_close
reads as
void dc_close(device_data_t *data);
and indeed "data" is accessed inside the function. I don't understand
how this doesn't crash, but clearly something is amiss.
Let's remove that connect statement.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
| -rw-r--r-- | desktop-widgets/configuredivecomputerdialog.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/desktop-widgets/configuredivecomputerdialog.cpp b/desktop-widgets/configuredivecomputerdialog.cpp index 6fd855648..d7d6fb8ba 100644 --- a/desktop-widgets/configuredivecomputerdialog.cpp +++ b/desktop-widgets/configuredivecomputerdialog.cpp @@ -347,7 +347,6 @@ void OstcFirmwareCheck::saveOstcFirmware(QNetworkReply *reply) connect(config, SIGNAL(message(QString)), dialog, SLOT(setLabelText(QString))); connect(config, SIGNAL(error(QString)), dialog, SLOT(setLabelText(QString))); connect(config, SIGNAL(progress(int)), dialog, SLOT(setValue(int))); - connect(dialog, SIGNAL(finished(int)), config, SLOT(dc_close())); config->dc_open(&devData); config->startFirmwareUpdate(storeFirmware, &devData); } |