summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2017-12-28 10:53:26 +0100
committerGravatar Jan Mulder <jlmulder@xs4all.nl>2017-12-28 13:22:51 +0100
commitc032006d91ee3cce7d9267ff9a1c39ac7087d272 (patch)
tree68eae4355b2c49df2ca8c9eecdec9ad680ae8c99
parentc3b1c641837a441734ee9c525f5ed3699735c18c (diff)
downloadsubsurface-c032006d91ee3cce7d9267ff9a1c39ac7087d272.tar.gz
Replace less-or-equal by less-than comparison in lessThan function
DiveLocationFilterProxyModel::lessThan() used less-or-equal instead of less-than comparison. This can lead to subtle bugs if two elements compare as equal. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--desktop-widgets/locationinformation.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/desktop-widgets/locationinformation.cpp b/desktop-widgets/locationinformation.cpp
index 5212b0bf9..f10b2b766 100644
--- a/desktop-widgets/locationinformation.cpp
+++ b/desktop-widgets/locationinformation.cpp
@@ -358,7 +358,7 @@ bool DiveLocationFilterProxyModel::filterAcceptsRow(int source_row, const QModel
bool DiveLocationFilterProxyModel::lessThan(const QModelIndex &source_left, const QModelIndex &source_right) const
{
- return source_left.data().toString() <= source_right.data().toString();
+ return source_left.data().toString() < source_right.data().toString();
}