summaryrefslogtreecommitdiffstats
path: root/INSTALL
diff options
context:
space:
mode:
authorGravatar Dirk Hohndel <dirk@hohndel.org>2020-05-14 12:15:24 -0700
committerGravatar Lubomir I. Ivanov <neolit123@gmail.com>2020-05-15 02:49:46 +0300
commit658089d763c1e9e953f5c06b01d028613408138b (patch)
tree658c0c14547e36a940f2b0a927c626b3505d939b /INSTALL
parent62e95fdc8656a0c8fdb181c3fe0a48e043650a05 (diff)
downloadsubsurface-658089d763c1e9e953f5c06b01d028613408138b.tar.gz
core/bt: match DC descriptor in lower case
This fixes a rather subtle bug. In btdiscovery.cpp we are detecting dive computers based on their BT name and are setting up product+vendor as the key for that lookup. QMap always uses case sensitive comparisons and a tiny inconsistency snuck into our code. libdivecomputer names for the Aqualung dive computers i200C / i300C / i550C end in an upper case C (as matches the official branding), but in btdiscovery.cpp we have those names with lower case c. And therefore didn't recognize these dive computers. Obviously this is easy to fix by fixing those three strings, but I decided that it was silly to set ourselves up for similar oversights in the future. So instead I switched the matching of the descriptor to simply be allways all lower case. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'INSTALL')
0 files changed, 0 insertions, 0 deletions