diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2017-11-18 16:06:41 +0100 |
|---|---|---|
| committer |  Lubomir I. Ivanov <neolit123@gmail.com> | 2017-11-20 20:56:13 +0100 |
| commit | dd8e4fae2aa31f1fac2a8a6f086db0db0a3209c6 (patch) | |
| tree | 5bf0f8872a35f71430733c9766bc70ad65cea499 /core/dive.h | |
| parent | e762fd2d416cbe77669a83e302709aa3fbda68f7 (diff) | |
| download | subsurface-dd8e4fae2aa31f1fac2a8a6f086db0db0a3209c6.tar.gz | |
Make handling of booleans consistent on the C++-side of preferences
In general, the C++-side of the preferences code consistently uses
the bool data type for boolean settings. There are five exceptions,
which use short instead:
showPo2
showPn2
showPhe
saveUserIdLocal
displayInvalidDives
This patch attempts to make the code more consistent by turning
these into bools as well.
Tests showed that writing as short and reading as bool is handled
gracefully by the Qt variant code. Therefore, an upgrade should not
cause user-visible changes to their settings.
As a bonus, two extern declarations of the set_save_userid_local()
function, which is not defined anywhere, were removed.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core/dive.h')
| -rw-r--r-- | core/dive.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/core/dive.h b/core/dive.h index 5a87eb602..0f6fe192d 100644 --- a/core/dive.h +++ b/core/dive.h @@ -1012,7 +1012,6 @@ extern double strtod_flags(const char *str, const char **ptr, unsigned int flags #define ascii_strtod(str, ptr) strtod_flags(str, ptr, STRTOD_ASCII) -extern void set_save_userid_local(short value); extern void set_userid(char *user_id); extern void set_informational_units(char *units); extern void set_git_prefs(char *prefs); |