diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-12-10 14:49:32 +0100 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-12-17 07:37:32 -0800 |
| commit | bfe69239df6a8d2b2ae986b850246727a21e127b (patch) | |
| tree | 04c5eeb37790f81861f80a93b28fa752d9a1fe9b /core/divelist.c | |
| parent | a6a5cf61e2f45eb54721c7ee2dbcc05afe8939f9 (diff) | |
| download | subsurface-bfe69239df6a8d2b2ae986b850246727a21e127b.tar.gz | |
Import: unglobalize downloadTable
To make data flow more clear, unglobalize the downloadTable object.
Make it a subobject of DownloadThread. The difficult part was making
this compatible with QML, because somehow the pointer to the
download-table has to be passed to the DiveImportedModel. Desktop would
simply pass it to the constructor. But with objects generated in QML
this is not possible. Instead, pass the table in the repopulate()
function. This seems to make sense, but for this to work, we have to
declare pointer-to-dive-table as a Q_METATYPE. And this only works
if we use a typedef, because MOC removes the "struct" from "struct
dive_table". This leads to compilation errors, because dive_table is
the symbol-name of the global dive table! Sigh.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core/divelist.c')
| -rw-r--r-- | core/divelist.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/core/divelist.c b/core/divelist.c index 4b809da37..4659261cd 100644 --- a/core/divelist.c +++ b/core/divelist.c @@ -74,9 +74,6 @@ dive_trip_t *dive_trip_list; unsigned int amount_selected; -// We need to stop using globals, really. -struct dive_table downloadTable; - #if DEBUG_SELECTION_TRACKING void dump_selection(void) { |